Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Header #48

Closed
istvank opened this issue Feb 22, 2016 · 2 comments
Closed

Version Header #48

istvank opened this issue Feb 22, 2016 · 2 comments

Comments

@istvank
Copy link
Contributor

istvank commented Feb 22, 2016

Hi, first again thanks for the great work! :bowtie: Now to my issue: On the y-websockets-server page you describe that the Yjs version of the Web application and of the y-websockets-server have to be the same:

You have to make sure that the installed yjs package version matches the yjs version used on the client side!

However, if they are different, I get no error. This is especially confusing as I never know which y-websockets-server the "Demo" server provided by you is currently running on. It would be neat to have some kind of versioning header in the initial connection that would throw an error or at least a log message in the browser, that the Yjs versions on client and server are inconsistent.

Even if I employ my own y-websockets-server, I regularly do "bower update" before releasing the client. This occasionally updates the Yjs version, but not the one on the server.

Do you think some kind of hints would be feasible?

@dmonad
Copy link
Member

dmonad commented Feb 23, 2016

This was rather easy to implement & totally makes sense. The update will take place when I upgrade the current default server (in the next two weeks). In order to use this feature, both client (and server) need to implement Yjs > 0.8.28

Thanks for the report!

@dmonad dmonad closed this as completed Feb 23, 2016
@dmonad dmonad mentioned this issue Feb 23, 2016
@istvank
Copy link
Contributor Author

istvank commented Feb 23, 2016

Thank you! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants