New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting Doc.gc value in Doc's constructor #176

Closed

calibr wants to merge 1 commit into yjs:master from calibr:yjs

Contributor

calibr commented Dec 10, 2019 •

edited by huly-github bot

now it is impossible to disable gc in a document, because Doc's constructor always sets gc to true regardless of config

_{Huly®: YJS-691}


          fix setting Doc.gc value in Doc's constructor

2b24af1

dmonad closed this in

22917bc

Member

dmonad commented Dec 10, 2019

Right, I don't know what I was thinking there. Thanks for bringing that up. I fixed the issue in another PR to also create proper typings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment