-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the way that we set up the Org template for notes. #340
Conversation
I figure if (heaven forbid) Org continues to change this variable in backward-incompatible ways we now have a nice place to set up a cascading |
This PR fixes a critical error regarding new definition of And the change should also be merged to the |
The way that Org does templates has changed. "<*"-style templates now require the org-tempo package, and org-structure-template-alist has changed. Now it is a list of cons pairs of the form "(key . block-name)". This creates an expansion from "<key" to "#+begin_block-name\n\n#+end_block-name".
Thanks for commenting on this, looking back I realized I made an error with the version check that might break things in the future. The fixed version of the PR is still critical though, thanks for bumping! For reference: The version change appeared in c04e357f3d5d93484277a7e439847b1233b872bd. Further discussion of the relevant Org commits is in #327. |
I'm currently hitting this issue with the latest update to org mode, any idea if it will go forward and released in |
|
Now we can use a new forked repository: https://gitlab.com/oer/emacs-reveal |
Done by 1b7957f. |
Thanks for that merge. However, I'd like to request that the version check code be amended. This PR uses a very specific way of checking the version, as my local way of installing Org doesn't successfully set |
OK, no problem. Have updated according to your suggestion. |
Continuation of #327, using the version property of a specific variable rather than the version of Org itself.