Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way that we set up the Org template for notes. #340

Closed
wants to merge 1 commit into from
Closed

Fix the way that we set up the Org template for notes. #340

wants to merge 1 commit into from

Conversation

jaccarmac
Copy link

Continuation of #327, using the version property of a specific variable rather than the version of Org itself.

@jaccarmac
Copy link
Author

I figure if (heaven forbid) Org continues to change this variable in backward-incompatible ways we now have a nice place to set up a cascading cond of version-dependent configuration changes.

@takaxp
Copy link

takaxp commented Sep 17, 2018

This PR fixes a critical error regarding new definition of org-structure-template-alist, so should be merged at least by Org 9.2 release otherwise many users will confuse.

And the change should also be merged to the stable branch in this repository so that MELPA users can use new code too.

The way that Org does templates has changed. "<*"-style templates now require
the org-tempo package, and org-structure-template-alist has changed. Now it is
a list of cons pairs of the form "(key . block-name)". This creates an
expansion from "<key" to "#+begin_block-name\n\n#+end_block-name".
@jaccarmac
Copy link
Author

Thanks for commenting on this, looking back I realized I made an error with the version check that might break things in the future. The fixed version of the PR is still critical though, thanks for bumping!

For reference: The version change appeared in c04e357f3d5d93484277a7e439847b1233b872bd. Further discussion of the relevant Org commits is in #327.

@tjsousa
Copy link

tjsousa commented Jan 3, 2019

I'm currently hitting this issue with the latest update to org mode, any idea if it will go forward and released in ox-reveal?

@driftcrow
Copy link

(setq org-reveal-note-key-char nil)

@takaxp
Copy link

takaxp commented Jan 13, 2019

We can find additional related PRs 💯

#359
#361
#362

@takaxp
Copy link

takaxp commented Feb 5, 2019

Now we can use a new forked repository: https://gitlab.com/oer/emacs-reveal
see also #363

@yjwen
Copy link
Owner

yjwen commented Jun 9, 2019

Done by 1b7957f.
Thanks.

@yjwen yjwen closed this Jun 9, 2019
@jaccarmac
Copy link
Author

Thanks for that merge. However, I'd like to request that the version check code be amended. This PR uses a very specific way of checking the version, as my local way of installing Org doesn't successfully set org-version. By checking the version on the specific variable as in https://github.com/yjwen/org-reveal/pull/340/files#diff-6d8f0c59126b393965f0226829b47a30R1283, the patch will work regardless of org-version. I can provide another smaller PR if necessary.

@yjwen
Copy link
Owner

yjwen commented Jun 10, 2019

OK, no problem. Have updated according to your suggestion.

@jaccarmac jaccarmac deleted the fix-org-structure-template-alist branch June 10, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants