Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the pull request #31 thoroughly #32

Closed
ykdojo opened this issue Feb 16, 2024 · 4 comments
Closed

Review the pull request #31 thoroughly #32

ykdojo opened this issue Feb 16, 2024 · 4 comments

Comments

@ykdojo
Copy link
Owner

ykdojo commented Feb 16, 2024

#31

@ykdojo ykdojo changed the title Review #31 Review the pull request #31 Feb 16, 2024
@ykdojo ykdojo changed the title Review the pull request #31 Review the pull request thoroughly #31 Feb 16, 2024
@ykdojo
Copy link
Owner Author

ykdojo commented Feb 16, 2024

I'm thinking a self-review might be a valid option here.

Steps I'd take to do this:

  1. Set up a screen recording environment, for example with Loom
  2. First, walk through which files were changed and how
  3. Then, show how it's set up and can be developed (ideally from scratch)
  4. Also explain the changes in README if you haven't yet

@ykdojo ykdojo changed the title Review the pull request thoroughly #31 Review the pull request #31 thoroughly Feb 17, 2024
@ykdojo
Copy link
Owner Author

ykdojo commented Feb 17, 2024

Feedback on the video quality:

  1. There's a significant amount of noise. I'm not sure if it's easy to fix though. Perhaps we can add noise cancellation to OpenStream itself at some point in the future to mitigate issues like this.
  2. Would be helpful for you to speak slightly more slowly, I think. Just more clarity would be helpful.

Other than that, very cool! Thank you so much. I'll merge your PR.

@ykdojo ykdojo closed this as completed Feb 17, 2024
@omar-shahid
Copy link
Contributor

Thanks @ykdojo, it's my first time recording videos, thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants