Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to plasmo + react #31

Merged
merged 5 commits into from
Feb 17, 2024
Merged

Switch to plasmo + react #31

merged 5 commits into from
Feb 17, 2024

Conversation

omar-shahid
Copy link
Contributor

@omar-shahid omar-shahid commented Feb 15, 2024 •
edited
Loading

Adresses

Description

  • Initliazed Plasmo + React
  • Migrated example screenshot code from vanilla JS to Plasmo + React
  • Entry point is now: popup.tsx

Preview

image

@ykdojo
Copy link
Owner

ykdojo commented Feb 15, 2024

Thank you. No change in the installation instructions in README?

@ykdojo
Copy link
Owner

ykdojo commented Feb 15, 2024

Also a note on how to go about further developing this in README would be helpful.

@omar-shahid
Copy link
Contributor Author

@ykdojo done

@ykdojo ykdojo mentioned this pull request Feb 16, 2024
Closed
@ykdojo
Copy link
Owner

ykdojo commented Feb 16, 2024

Thank you!

Created #32 for a more thorough review.

@ykdojo ykdojo merged commit 95b0617 into ykdojo:main Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
OpenStream Main
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omar-shahid @ykdojo