Skip to content

Commit

Permalink
Just cleaned up the code to make it more consistent (name convention)
Browse files Browse the repository at this point in the history
  • Loading branch information
ykdojo committed Nov 26, 2018
1 parent c7d224b commit 0703f1d
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 16 deletions.
12 changes: 6 additions & 6 deletions editdojo_project/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@
"""
from django.contrib import admin
from django.urls import path, include
from hello.views import myView, homeView
from todo.views import todoView, addTodo, deleteTodo
from hello.views import my_view, home_view
from todo.views import todo_view, add_todo, delete_todo
from auth.views import login

urlpatterns = [
path('admin/', admin.site.urls),
path('accounts/', include('allauth.urls')),

path('sayHello/', myView),
path('sayHello/', my_view),

path('todo/', todoView),
path('addTodo/', addTodo),
path('deleteTodo/<int:todo_id>/', deleteTodo),
path('todo/', todo_view),
path('addTodo/', add_todo),
path('deleteTodo/<int:todo_id>/', delete_todo),

path('', login, name='home'),
]
4 changes: 2 additions & 2 deletions hello/views.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from django.shortcuts import render
from django.http import HttpResponse

def myView(request):
def my_view(request):
return HttpResponse('Hello, World Ahhh!')

def homeView(request):
def home_view(request):
return HttpResponse('This is home page')
5 changes: 0 additions & 5 deletions templates/todo.html
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
<h1>this is the todo page.</h1>

<!-- <ul>
<li>temporary todo item A</li>
<li>temporary todo item B</li>
</ul> -->

<ul>
{% for todo_item in all_items %}
<li>{{ todo_item.content }}
Expand Down
6 changes: 3 additions & 3 deletions todo/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@
from django.http import HttpResponseRedirect
from .models import TodoItem

def todoView(request):
def todo_view(request):
all_todo_items = TodoItem.objects.all()
return render(request, 'todo.html',
{'all_items': all_todo_items})

def addTodo(request):
def add_todo(request):
new_item = TodoItem(content = request.POST['content'])
new_item.save()
return HttpResponseRedirect('/todo/')

def deleteTodo(request, todo_id):
def delete_todo(request, todo_id):
item_to_delete = TodoItem.objects.get(id=todo_id)
item_to_delete.delete()
return HttpResponseRedirect('/todo/')

0 comments on commit 0703f1d

Please sign in to comment.