Added function for detecting message lang #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I may have found a possible solution to the above problem by iterating through the Language objects that are returned when calling detect_langs(), and checking to see if any of the probable languages match either the user's target language or native language. Will push a second commit when I get home. |
|
Thank you. I'll take a look at this after I publish my next video about #22. |
ykdojo
reviewed
Nov 25, 2018
| init_time = time.time() | ||
| while True: | ||
| # if native/target lang is not detected after five seconds, return None | ||
| if (time.time()-init_time) >= 5: |
There was a problem hiding this comment.
Thank you for this. Just curious, why did you decide to go with the approach of limiting this with time? (As opposed to the number of loops, for example)
Tipuch
suggested changes
Dec 1, 2018
| # if native/target lang is not detected (due to langdetect probability algorithm) then generate new probabilities | ||
| # until native/target lang is detected | ||
| else: | ||
| init_time = time.time() |
There was a problem hiding this comment.
Suggested change
| init_time = time.time() | |
| prob_list = detect_langs(message_text) | |
| for item in prob_list: | |
| if item.lang == user_target_lang or item.lang == user_native_lang: | |
| return item.lang | |
| return None |
the code you have below should work perfectly well by itself, I don't understand the purpose of the while loop in your algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and made a basic function for detecting the language of a message, in order to identify it as either being typed in the user's target language (so it can be seen by other users) or native language (so it can be ignored).
I did run into an issue concerning the langdetect library; due to the nature of the library's probability-based algorithm, it will occasionally misidentify a message's language if the message contains spelling errors. For example, "Hello World!" will return English, while "Helo Woorld!" will return Dutch. I could use some help coming up with a solution for this problem.