Some changes #7
Merged
Some changes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... change linter to extra_pedantic, lower the version constraint, remove unnecessary newlines, prefer snake case, don't warn on newlines and output a newline, avoid vars, don't prefer single quoted string literals.
and move the meat of the implementation to the lib folder so that fire can be tested with fire.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ykmnkmi,
This PR is rather huge compared to the previous ones. I have some strong opinions on code style that have been enforced here. I'd be understanding If you'd prefer to rather stick to the existing style and copy the fix to #5 over manually.
Notable non codestyle related changes are: