Merge pull request dsccommunity#378 from PowerShell/release-1.2

Release 1.2
ykuijs · Aug 10, 2016 · 08718bf · 08718bf
2 parents 805244b + 869d9b6
commit 08718bf
Show file tree

Hide file tree

Showing 196 changed files with 5,082 additions and 1,003 deletions.
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
@@ -1 +1 @@
-If you'd like to contribute to this project, please review the [Contribution Guidelines](https://github.com/powershell/xSharePoint/wiki/Contributing%20to%20xSharePoint).
+If you'd like to contribute to this project, please review the [Contribution Guidelines](https://github.com/powershell/SharePointDsc/wiki/Contributing%20to%20SharePointDsc).
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
@@ -1,5 +1,7 @@
 _Please provide the following information regarding your issue (place N/A if certain fields don't apply in your case:_
 
+**DELETE THIS LINE AND ABOVE**
+
 **Details of the scenario you try and problem that is occurring:**
 
 **The DSC configuration that is using the resource:**
@@ -8,8 +10,10 @@ _Please provide the following information regarding your issue (place N/A if cer
 
 **Version of the DSC module you're using:**
 
-_Your feedback and support is greatly appreciated._
 
+**DELETE THIS LINE AND BELOW**
+
+_Your feedback and support is greatly appreciated._
 
 _If you are able to resolve this issue or add new features, you may submit a Pull Request against this project._
 _Please see the [Contribution Guideliness](https://github.com/powershell/xSharePoint/wiki/Contributing%20to%20xSharePoint) for information on how to contribute._
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,12 +1,20 @@
 Thanks for submitting a Pull Request to this project.
+This template will help you create your pull request.
 
 Please make sure you have read the [Contribution Guidelines](https://github.com/powershell/xSharePoint/wiki/Contributing%20to%20xSharePoint).
 
 To aid community reviewers in reviewing and merging your PR, please take the time to run through this checklist:
-- [ ] Change details added to Unreleased section of readme.md?
+
+**DELETE THIS LINE AND ABOVE**
+
+[Replace this with a description of your pull request]
+
+- [ ] Change details added to Unreleased section of changelog.md?
 - [ ] Added/updated documentation and descriptions in .schema.mof files where appropriate?
 - [ ] Examples updated for both the single server and small farm templates in the examples folder?
 - [ ] New/changed code adheres to [Style Guidelines]?(https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?
 - [ ] [Unit and Integration tests](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md) created/updated where possible?
 
+**DELETE THIS LINE AND BELOW**
+
 Your contribution to this project is greatly appreciated. 
diff --git a/.vscode/RunGlobalTests.ps1 b/.vscode/RunGlobalTests.ps1
@@ -1,4 +1,4 @@
-Import-Module (Join-Path $PSScriptRoot "..\Tests\SharePointDsc.TestHarness.psm1")
+Import-Module (Join-Path $PSScriptRoot "..\Tests\Unit\SharePointDsc.TestHarness.psm1")
 
 $DscTestsPath = Join-Path $PSScriptRoot "..\Modules\SharePointDsc\DscResource.Tests"
 if ((Test-Path $DscTestsPath) -eq $false) {

diff --git a/.vscode/RunPesterTests.ps1 b/.vscode/RunPesterTests.ps1
@@ -1,10 +1,10 @@
-Import-Module (Join-Path $PSScriptRoot "..\Tests\SharePointDsc.TestHarness.psm1"  -Resolve) -Force
+Import-Module (Join-Path $PSScriptRoot "..\Tests\Unit\SharePointDsc.TestHarness.psm1"  -Resolve) -Force
 
 $DscTestsPath = Join-Path $PSScriptRoot "..\Modules\SharePointDsc\DscResource.Tests" -Resolve
 if ((Test-Path $DscTestsPath) -eq $false) {
     Write-Warning "Unable to locate DscResource.Tests repo at '$DscTestsPath', common DSC resource tests will not be executed"
-    Invoke-SPDSCTests -CalculateTestCoverage $false
+    Invoke-SPDscUnitTestSuite -CalculateTestCoverage $false
 } else {
-    Invoke-SPDSCTests -DscTestsPath $DscTestsPath -CalculateTestCoverage $false
+    Invoke-SPDscUnitTestSuite -DscTestsPath $DscTestsPath -CalculateTestCoverage $false
 }
 
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,21 @@
 # Change log for SharePointDsc
 
+### 1.2
+
+ * Fixed bugs SPWebAppPolicy and SPServiceApPSecurity that prevented the get methods from returning AD group names presented as claims tokens
+ * Minor tweaks to the PowerShell module manifest
+ * Modified all resources to ensure $null values are on the left of comparisson operations
+ * Added RunOnlyWhenWriteable property to SPUserProfileSyncService resource
+ * Added better logging to all test method output to make it clear what property is causing a test to fail
+ * Added support for NetBIOS domain names resolution to SPUserProfileServiceApp
+ * Removed chocolatey from the AppVeyor build process in favour of the PowerShell Gallery build of Pester
+ * Fixed a bug in SPContentDatabase that caused it to not function correctly. 
+ * Fixed the use of plural nouns in cmdlet names within the module
+ * Removed dependency on Win32_Product from SPInstall
+ * Added SPTrustedIdentityTokenIssuer, SPRemoteFarmTrust and SPSearchResultSource resources
+ * Added HostHeader parameter in examples for Web Application, so subsequent web applications won't error out
+ * Prevented SPCreateFarm and SPJoinFarm from executing set methods where the local server is already a member of a farm 
+
 ### 1.1
 
  * Added SPBlobCacheSettings, SPOfficeOnlineServerBinding, SPWebAppPermissions, SPServiceAppProxyGroup, SPWebAppProxyGroup and SPUserProfileServiceAppPermissions resources
@@ -111,4 +127,4 @@
 ### 0.2.0
 
 * Initial public release of xSharePoint
- 
+
diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPAccessServiceApp/MSFT_SPAccessServiceApp.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPAccessServiceApp/MSFT_SPAccessServiceApp.psm1
@@ -95,7 +95,7 @@ function Test-TargetResource
     $PSBoundParameters.Ensure = $Ensure
     Write-Verbose -Message "Testing for Access Service Application '$Name'"
     $CurrentValues = Get-TargetResource @PSBoundParameters
-    return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("Ensure")
+    return Test-SPDscParameterState -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("Ensure")
 }
 
 Export-ModuleMember -Function *-TargetResource
diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPAlternateUrl/MSFT_SPAlternateUrl.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPAlternateUrl/MSFT_SPAlternateUrl.psm1
@@ -109,11 +109,11 @@ function Test-TargetResource
     Write-Verbose -Message "Testing alternate URL configuration"
     if ($Ensure -eq "Present")
     {
-        return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("Url", "Ensure")
+        return Test-SPDscParameterState -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("Url", "Ensure")
     }
     else 
     {
-        return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("Ensure")
+        return Test-SPDscParameterState -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("Ensure")
     }
 
 }

diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPAntivirusSettings/MSFT_SPAntivirusSettings.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPAntivirusSettings/MSFT_SPAntivirusSettings.psm1
@@ -112,7 +112,7 @@ function Test-TargetResource
 
     if ($null -eq $CurrentValues) { return $false }
 
-    return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters
+    return Test-SPDscParameterState -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters
 }
 
 Export-ModuleMember -Function *-TargetResource
diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPAppCatalog/MSFT_SPAppCatalog.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPAppCatalog/MSFT_SPAppCatalog.psm1
@@ -20,7 +20,7 @@ function Get-TargetResource
         }
         $wa = $site.WebApplication
         $feature = $wa.Features.Item([Guid]::Parse("f8bea737-255e-4758-ab82-e34bb46f5828"))
-        if($feature -eq $null){
+        if($null -eq $feature) {
             return $null
         }
         if ($site.ID -ne $feature.Properties["__AppCatSiteId"].Value) {
@@ -62,10 +62,10 @@ function Test-TargetResource
 
     $CurrentValues = Get-TargetResource @PSBoundParameters
     Write-Verbose -Message "Testing app domain settings"
-    if($CurrentValues -eq $null){
+    if($null -eq $CurrentValues){
         return $false
     }
-    return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("SiteUrl") 
+    return Test-SPDscParameterState -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("SiteUrl") 
 }
 
 Export-ModuleMember -Function *-TargetResource
diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPAppDomain/MSFT_SPAppDomain.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPAppDomain/MSFT_SPAppDomain.psm1
@@ -59,7 +59,7 @@ function Test-TargetResource
 
     $CurrentValues = Get-TargetResource @PSBoundParameters
     Write-Verbose -Message "Testing app domain settings"
-    return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("AppDomain", "Prefix") 
+    return Test-SPDscParameterState -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("AppDomain", "Prefix") 
 }
 
 

diff --git a/...ePointDsc/DSCResources/MSFT_SPAppManagementServiceApp/MSFT_SPAppManagementServiceApp.psm1 b/...ePointDsc/DSCResources/MSFT_SPAppManagementServiceApp/MSFT_SPAppManagementServiceApp.psm1
@@ -126,7 +126,7 @@ function Test-TargetResource
     Write-Verbose -Message "Testing for App management Service Application '$Name'"
     $CurrentValues = Get-TargetResource @PSBoundParameters
 
-    return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("ApplicationPool", "Ensure")
+    return Test-SPDscParameterState -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("ApplicationPool", "Ensure")
 }
 
 Export-ModuleMember -Function *-TargetResource

diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPBCSServiceApp/MSFT_SPBCSServiceApp.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPBCSServiceApp/MSFT_SPBCSServiceApp.psm1
@@ -127,7 +127,7 @@ function Test-TargetResource
     Write-Verbose -Message "Testing for BCS Service Application '$Name'"
     $CurrentValues = Get-TargetResource @PSBoundParameters
 
-    return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("ApplicationPool", "Ensure")
+    return Test-SPDscParameterState -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("ApplicationPool", "Ensure")
 }
 
 Export-ModuleMember -Function *-TargetResource
diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPBlobCacheSettings/MSFT_SPBlobCacheSettings.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPBlobCacheSettings/MSFT_SPBlobCacheSettings.psm1
@@ -212,7 +212,7 @@ function Test-TargetResource
         }
     }
 
-    return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues `
+    return Test-SPDscParameterState -CurrentValues $CurrentValues `
                                               -DesiredValues $PSBoundParameters `
                                               -ValuesToCheck @("EnableCache", "Location", "MaxSizeInGB", "FileType", "MaxAgeInSeconds")
 }

diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPCacheAccounts/MSFT_SPCacheAccounts.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPCacheAccounts/MSFT_SPCacheAccounts.psm1
@@ -35,7 +35,7 @@ function Get-TargetResource
         if ($wa.UseClaimsAuthentication -eq $true) {
             if ($wa.Properties.ContainsKey("portalsuperuseraccount")) {
                 $claim = New-SPClaimsPrincipal -Identity $wa.Properties["portalsuperuseraccount"] -IdentityType EncodedClaim -ErrorAction SilentlyContinue
-                if ($claim -ne $null) {
+                if ($null -ne $claim) {
                     $returnVal.Add("SuperUserAlias", $claim.Value)
                 } else {
                     $returnVal.Add("SuperUserAlias", "")
@@ -45,7 +45,7 @@ function Get-TargetResource
             }
             if ($wa.Properties.ContainsKey("portalsuperreaderaccount")) {
                 $claim = New-SPClaimsPrincipal -Identity $wa.Properties["portalsuperreaderaccount"] -IdentityType EncodedClaim -ErrorAction SilentlyContinue
-                if ($claim -ne $null) {
+                if ($null -ne $claim) {
                     $returnVal.Add("SuperReaderAlias", $claim.Value)
                 } else {
                     $returnVal.Add("SuperReaderAlias", "")
@@ -164,7 +164,7 @@ function Test-TargetResource
     $CurrentValues = Get-TargetResource @PSBoundParameters
     $PSBoundParameters.SetWebAppPolicy = $SetWebAppPolicy
     Write-Verbose -Message "Testing cache accounts for $WebAppUrl"
-    return Test-SPDSCSpecificParameters -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("SuperUserAlias", "SuperReaderAlias", "SetWebAppPolicy")
+    return Test-SPDscParameterState -CurrentValues $CurrentValues -DesiredValues $PSBoundParameters -ValuesToCheck @("SuperUserAlias", "SuperReaderAlias", "SetWebAppPolicy")
 }
 
 Export-ModuleMember -Function *-TargetResource