Refacto puma-helper UI

[w3st3ry]

Related to #18

• Suppress the process index and start with the PID directly to simplify the line, start with "└" for the process to make it look like a child of the application line
• All numbers be padded on a fixed size to preserve alignment
• Process phase only displayed if it's different from application phase to save space, at the end of the line, in orange
• Uptime /w 1 space between number and letter, only pad the whole string to maintain alignment -> need this MR validated before do these changes https://github.com/dimelo/puma-helper/pull/20/files
• Last checkin disabled if there's an issue (> 10 sec)
• Delete headers lines
• Remove the number of workers per apps
• No digit in memory
• Throw errors at the end of the output
• MiB to M
• Active Threads / Threads to Load
• Sort workers by uptime
• Add queuing in worker line
• Better current CPU usage based on PID

[spuyet]

Thanks @w3st3ry that's a good start, here is my feedback:

• Drop the arrows at line beginning
• Drop the phase and app path
• Same app with different path should not be aggregated but considered as different apps
• There is no Times value asked in our requirements, drop it

Please try to have an output like the one we've asked.

[spuyet]

I will start to review the code once the output will match our expectations.

[ylecuyer]

I would add :

• % in CPU Av and M in Mem should either be removed or included into the coloring (personally I would remove them)
• CPU Av => Just 'CPU'

[w3st3ry]

@spuyet @ylecuyer I done the changes in the last commit, I'll update the screenshot.

Except "same app with different path should not be aggregated but considered as different apps", I asked myself the same thing as #14 (comment)

[ylecuyer]

Why did CPU and Mem disapeared ?

[w3st3ry]

@ylecuyer fixed. understood the opposite.
@spuyet WDYT about hide Queue field if it's equal to 0?

[jarthod]

Yes please hide the queue when it's 0, like the other warnings (phase, last update, etc..)

[ylecuyer]

Can you also rename "CPU Av" to just "CPU"

[spuyet]

Can you add some new screenshots once you've modified the output ?

[ylecuyer]

:/

[w3st3ry]

@spuyet done.
@ylecuyer fixed, normally it will works on any terminal now (not just iTerm :D)

[ylecuyer]

I'm not sure which version is on staging for the moment but the Mem output is not good:

It should be 237 not 237002752

[w3st3ry]

@ylecuyer I'm actually doing some tests (I can't test on my own env to have a perfect output), that's why. Don't worry, I'm aware of this.

[w3st3ry]

@spuyet @jarthod I used a new way to calculate the current CPU usage of a pid, based on a tiny lib who implement ps and an history. Tested locally, it works fine. Please give me your feedback about it.
I set the minimum timer to get an approx. average.

[jarthod]

Ok nice, can we test this somewhere?

[w3st3ry]

@jarthod on staging server.

[ylecuyer]

They are still issues with the display:

I'm not sure about the new CPU stats method. Now only available values are 0, 50, 100 or 200

[spuyet]

I checked on staging and the apps are still aggregated by name and should not:

answers_integration application
38423 (/home/answers_integration/current/tmp/pids/puma.state) | Load: 0[░░]2
 └ 12601 CPU: 0.0 Mem: 257 Uptime: 197h28m57s Load: 0[░]1
 └ 12789 CPU: 0.0 Mem: 254 Uptime: 197h28m51s Load: 0[░]1

38424 (/home/answers_integration/current/tmp/pids/puma_api.state) | Load: 0[░░]2
 └ 12560 CPU: 0.0 Mem: 184 Uptime: 197h28m57s Load: 0[░]1
 └ 12775 CPU: 0.0 Mem: 183 Uptime: 197h28m52s Load: 0[░]1

should be:

38423 answers_integration                      Load: 0[░░]2
 └ 12601 CPU: 0.0 Mem: 257M Uptime: 197h28m57s Load: 0[░]1
 └ 12789 CPU: 0.0 Mem: 254M Uptime: 197h28m51s Load: 0[░]1

38424 answers_integration_api                  Load: 0[░░]2
 └ 12560 CPU: 0.0 Mem: 184M Uptime: 197h28m57s Load: 0[░]1
 └ 12775 CPU: 0.0 Mem: 183M Uptime: 197h28m52s Load: 0[░]1

Please remove the pipe before the load and add some padding to keep it aligned. Also add back the memory unit please, we want to know if we're using kilobyte, megabyte, gigabyte, etc