Skip to content

Commit

Permalink
Changed usage of be_true and be_false in specs to be(true) and be(false)
Browse files Browse the repository at this point in the history
* This is due to a change in RSpec where be_true now passes with
  any object, except false or nil. be_false will pass with the
  false or nil, and fail with everything else.  More information on
  the change:

    https://rspec.lighthouseapp.com/projects/5645/tickets/931

  While I can understand why this change was made, any place in the
  specs where be_true and be_false was specified, the intention was
  to assert that either true or false *only* was being returned; we
  wanted the spec to fail if nil or any other object was returned.
  • Loading branch information
dkubb committed Apr 9, 2010
1 parent 70b8db7 commit bc9922c
Show file tree
Hide file tree
Showing 24 changed files with 371 additions and 369 deletions.
88 changes: 44 additions & 44 deletions lib/dm-core/spec/resource_shared_spec.rb
Expand Up @@ -36,7 +36,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end
end

Expand All @@ -47,7 +47,7 @@
end

it 'should return false' do
@return.should be_false
@return.should be(false)
end
end

Expand All @@ -60,7 +60,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end
end

Expand All @@ -73,7 +73,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end
end

Expand All @@ -87,7 +87,7 @@
end

it 'should return false' do
@return.should be_false
@return.should be(false)
end
end

Expand All @@ -100,7 +100,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end
end

Expand All @@ -114,7 +114,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end
end
end
Expand Down Expand Up @@ -259,15 +259,15 @@
end

it 'should successfully remove a resource' do
@return.should be_true
@return.should be(true)
end

it 'should mark the destroyed resource as readonly' do
@resource.should be_readonly
end

it "should return true when calling #{method} on a destroyed resource" do
@resource.__send__(method).should be_true
@resource.__send__(method).should be(true)
end

it 'should remove resource from persistent storage' do
Expand Down Expand Up @@ -367,7 +367,7 @@

it 'should not raise an exception' do
lambda {
@user.dirty?.should be_true
@user.dirty?.should be(true)
}.should_not raise_error(SystemStackError)
end
end
Expand All @@ -381,7 +381,7 @@

it 'should not raise an exception' do
lambda {
@user.dirty?.should be_true
@user.dirty?.should be(true)
}.should_not raise_error(SystemStackError)
end
end
Expand All @@ -390,13 +390,13 @@
before :all do
rescue_if @skip do
@user.children = [ @user.parent = @user_model.new(:name => 'Parent', :comment => @comment) ]
@user.save.should be_true
@user.save.should be(true)
end
end

it 'should not raise an exception' do
lambda {
@user.dirty?.should be_true
@user.dirty?.should be(true)
}.should_not raise_error(SystemStackError)
end
end
Expand All @@ -412,7 +412,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end
end

Expand All @@ -423,7 +423,7 @@
end

it 'should return false' do
@return.should be_false
@return.should be(false)
end
end

Expand All @@ -436,7 +436,7 @@
end

it 'should return false' do
@return.should be_false
@return.should be(false)
end
end

Expand All @@ -447,7 +447,7 @@
end

it 'should return false' do
@return.should be_false
@return.should be(false)
end
end

Expand All @@ -460,7 +460,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end
end

Expand All @@ -474,7 +474,7 @@
end

it 'should return false' do
@return.should be_false
@return.should be(false)
end
end

Expand All @@ -487,7 +487,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end
end

Expand All @@ -501,7 +501,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end
end
end
Expand Down Expand Up @@ -662,7 +662,7 @@
end

it 'should return false' do
@user.readonly?.should be_false
@user.readonly?.should be(false)
end
end

Expand All @@ -674,19 +674,19 @@
end

it 'should return false' do
@user.readonly?.should be_false
@user.readonly?.should be(false)
end
end

describe 'on a destroyed resource' do
before :all do
rescue_if @skip do
@user.destroy.should be_true
@user.destroy.should be(true)
end
end

it 'should return true' do
@user.readonly?.should be_true
@user.readonly?.should be(true)
end
end

Expand All @@ -699,7 +699,7 @@
end

it 'should return true' do
@user.readonly?.should be_true
@user.readonly?.should be(true)
end
end
end
Expand All @@ -726,7 +726,7 @@
end

it 'should return false' do
@return.should be_false
@return.should be(false)
end

it 'should call save hook expected number of times' do
Expand All @@ -742,7 +742,7 @@
end

it 'should return true even when resource is not dirty' do
@return.should be_true
@return.should be(true)
end

it 'should call save hook expected number of times' do
Expand All @@ -759,7 +759,7 @@
end

it 'should save a resource succesfully when dirty' do
@return.should be_true
@return.should be(true)
end

it 'should actually store the changes to persistent storage' do
Expand All @@ -779,7 +779,7 @@
end

it 'should not save an invalid resource' do
@user.__send__(method).should be_false
@user.__send__(method).should be(false)
end

it 'should call save hook expected number of times' do
Expand All @@ -799,13 +799,13 @@

it 'should save resource' do
pending_if !@user.respond_to?(:comments) do
@return.should be_true
@return.should be(true)
end
end

it 'should save the first resource created through new' do
pending_if !@user.respond_to?(:comments) do
@first_comment.new?.should be_false
@first_comment.new?.should be(false)
end
end

Expand All @@ -817,7 +817,7 @@

it 'should save the second resource created through the constructor' do
pending "Changing a belongs_to parent should add the resource to the correct association" do
@second_comment.new?.should be_false
@second_comment.new?.should be(false)
end
end

Expand Down Expand Up @@ -850,7 +850,7 @@

it 'should return true' do
pending_if !@user.respond_to?(:comments) do
@return.should be_true
@return.should be(true)
end
end

Expand Down Expand Up @@ -879,7 +879,7 @@

it 'should not raise an exception when saving the resource' do
pending do
lambda { @first_comment.send(method).should be_false }.should_not raise_error
lambda { @first_comment.send(method).should be(false) }.should_not raise_error
end
end
end
Expand All @@ -897,7 +897,7 @@
end

it 'should succesfully save the resource' do
@return.should be_true
@return.should be(true)
end

it 'should not have a dirty dependency' do
Expand Down Expand Up @@ -954,7 +954,7 @@
end

it 'should save a resource succesfully when dirty' do
@return.should be_true
@return.should be(true)
end

it 'should actually store the changes to persistent storage' do
Expand All @@ -980,7 +980,7 @@
end

it 'should return true' do
@response.should be_true
@response.should be(true)
end

it 'should save the child' do
Expand Down Expand Up @@ -1031,7 +1031,7 @@

it 'should not raise an exception' do
lambda {
@user.__send__(method).should be_true
@user.__send__(method).should be(true)
}.should_not raise_error(SystemStackError)
end
end
Expand All @@ -1045,7 +1045,7 @@

it 'should not raise an exception' do
lambda {
@user.__send__(method).should be_true
@user.__send__(method).should be(true)
}.should_not raise_error(SystemStackError)
end
end
Expand All @@ -1059,7 +1059,7 @@

it 'should not raise an exception' do
lambda {
@user.__send__(method).should be_true
@user.__send__(method).should be(true)
}.should_not raise_error(SystemStackError)
end
end
Expand Down Expand Up @@ -1099,7 +1099,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end

it 'should update attributes of Resource' do
Expand All @@ -1121,7 +1121,7 @@
end

it 'should return true' do
@return.should be_true
@return.should be(true)
end

it 'should update attributes of Resource' do
Expand All @@ -1142,7 +1142,7 @@
end

it 'should return false' do
@return.should be_false
@return.should be(false)
end

it 'should not persist the changes' do
Expand Down

0 comments on commit bc9922c

Please sign in to comment.