Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution Type not mandatory #69

Closed
brusilva84 opened this issue Feb 13, 2023 · 11 comments
Closed

Solution Type not mandatory #69

brusilva84 opened this issue Feb 13, 2023 · 11 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@brusilva84
Copy link

The solution type check is not being applied.

I've setup up as required but tickets can be closed without it

@yllen yllen self-assigned this Feb 13, 2023
@yllen yllen added the question Further information is requested label Feb 13, 2023
@yllen
Copy link
Owner

yllen commented Feb 13, 2023

Version of GLPI?
Version of Behaviors plugin?

@brusilva84
Copy link
Author

GLPI: 10.0.6
Behaviors: 2.7.2

@CorentinS6
Copy link

Hello
I have the same issue. Same versions.
Regards

@BrunoRomeroDev
Copy link

BrunoRomeroDev commented Feb 24, 2023

Eu alterei a função isset() para empty() na linha 59 e funcionou em itilsolution.class. Sugeri o commit no repositorio.

@brusilva84
Copy link
Author

Yes it worked

Thanks

yllen added a commit that referenced this issue Mar 1, 2023
@yllen yllen added bug Something isn't working waiting approbation requester and removed question Further information is requested labels Mar 1, 2023
@yllen yllen added this to the 2.7.3 milestone Mar 1, 2023
@CorentinS6
Copy link

Tank you for 9bc20f3 👍
@yllen , is it possible to hide solution "Add" button when there is no solution type, or add a javascript warning. Currently, the form is send, and the solution description is lost. Frustrating.

@CorentinS6
Copy link

@yllen , what about my idea ?

@yllen yllen mentioned this issue Oct 2, 2023
@thierrydvi
Copy link

Hi,
When do you plan to put version 2.7.3 into production?
Best regards.

@tuxxic
Copy link

tuxxic commented Nov 10, 2023

@yllen I tested it in my environment, GLPI 10.0.10 and the master version of behaviors, and I have the popup as expected :
AD0285FF

You can safely publish the 2.7.3 version in case ! :)

@yllen
Copy link
Owner

yllen commented Nov 10, 2023

@CorentinS6 i can't do that without making a fork of GLPI core, sorry

@thierrydvi
Copy link

The marketplace does not offer the update and when we go to the page, the latter indicates 2.6.1 as the latest version instead of 2.7.3 even though it is present in the update history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants