Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a middleware message #49

Merged
merged 2 commits into from Jan 14, 2023
Merged

Implement a middleware message #49

merged 2 commits into from Jan 14, 2023

Conversation

peterfox
Copy link
Collaborator

@peterfox peterfox commented Jan 14, 2023

Changes In Code

Adds the ability to provide a string or translatable key to use with the middleware as a message for the response.

Issue ticket number / Business Case

It allows for more flexibility with the middleware to explain why a feature is not accessible.

Checklist before requesting a review

  • I have written PHP tests.
  • I have updated the documentation in the readme where needed.
  • I have checked code styles, PHPStan etc. pass.
  • I have provided an issue/business case.

@codecov-commenter
Copy link

Codecov Report

Merging #49 (c2a8044) into main (08a47dd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #49   +/-   ##
=========================================
  Coverage     80.08%   80.08%           
  Complexity      170      170           
=========================================
  Files            27       27           
  Lines           462      462           
=========================================
  Hits            370      370           
  Misses           92       92           
Impacted Files Coverage Δ
src/Middlewares/GuardFeature.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peterfox peterfox merged commit 29506de into main Jan 14, 2023
@peterfox peterfox deleted the feature/middleware-message branch January 14, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants