fix: callback handlers for queue workers #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a queue worker, each notification resets the scope. The problem here is that when this happens, all of the callbacks that were registered are no longer available - this is because they were all registered to a scoped singleton. I'm not sure how anyone else is able to use this package with a queue worker - out of the box it only works on "sync" mode, unless we remove the scoped singleton. In-fact, I'm curious as to why the singleton was scoped in the first place as part of the laravel 9 compatibility upgrades?
|
Just following up on this |
|
Your pull request works for me - thanks for that! |
peterfox
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a queue worker, each notification resets the scope. The problem here is that when this happens, all of the callbacks that were registered are no longer available - this is because they were all registered to a scoped singleton. I'm not sure how anyone else is able to use this package with a queue worker - out of the box it only works on "sync" mode, unless we remove the scoped singleton.
In-fact, I'm curious as to why the singleton was scoped in the first place as part of the laravel 9 compatibility upgrades?