Skip to content

Commit

Permalink
Update: try for issue #30 works for python >= 2.7.3
Browse files Browse the repository at this point in the history
  • Loading branch information
ymattw committed Sep 27, 2013
1 parent 12efc9d commit 2d2815a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cdiff.py
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def _forward_line(self):
self._in.write(line.encode('utf-8'))
except StopIteration:
# XXX: close() does not notify select() for EOF event in python
# 2.x, one of these two interface must be buggy
# < 2.7.3, one of these two interface must be buggy
#
# Sending EOF manually does not work either
#
Expand All @@ -273,7 +273,7 @@ def __iter__(self):
self._forward_line()
else:
#print('no data to read and istream closed')
# XXX: `close` or `select` seems buggy in python 2.x, select
# XXX: `close` or `select` seems buggy in python < 2.7.3, select
# does not tell ready event on _translator.stdout anymore once
# the stdin is closed. Just add a timeout here to detect, when
# that happen the remaining in output stream will be discarded
Expand Down

0 comments on commit 2d2815a

Please sign in to comment.