Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

OS-15: Ability to filter and sort locations by amenities offered #1005

Merged
merged 18 commits into from Apr 24, 2018

Conversation

dimb
Copy link
Contributor

@dimb dimb commented Apr 16, 2018

Task: As a person who is being served by the Y, I should be able to I should be able to use the amenities list to filter out the locations that do not have the amenities I want to use. I should be able to filter the locations by the amenities search. I should be taken to the Location Content page when clicking on a location block within the returned filtered results.

Steps for review:

  • Go to the /locations page.
  • There is an amenities list in the sidebar.
  • Choose amenities to filter locations.

Notes. I didn't change the page with the current search by amenities ( /amenities ) and the link from locations page to support all previous installations.
//cc @kolesnikoff

@dimb dimb requested a review from podarok April 16, 2018 21:29
@podarok
Copy link
Contributor

podarok commented Apr 17, 2018

ok to test

@podarok
Copy link
Contributor

podarok commented Apr 17, 2018

I see a bunch of config files changed and created
We should take care about upgrade path
Please, ensure you are following the document https://github.com/ymcatwincities/openy/blob/8.x-1.x/docs/Development/Upgrade%20path.md and provide upgrade path code before getting merged

@podarok podarok added PR: Needs Work Unfinished task. Issues still there Level: Middle Needs skilled developer to work on Status: Needs work Unfinished task. Issues still there Type: Enhancement Change request. New functionality. labels Apr 17, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Apr 17, 2018
@gundevel
Copy link
Collaborator

Build comment file:

Environment Link
Fresh OpenY installation http://openy.cibox.tools/build277
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build277
Installation process http://install.openy-dev.ffwua.com/build277/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/277/

@gundevel
Copy link
Collaborator

Acessibility Sniffer: front page checking WCAG2AA http://ci.openymca.org/build277/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://ci.openymca.org/build277/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://ci.openymca.org/build277/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://ci.openymca.org/build277/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://ci.openymca.org/build277/blogWCAG2AAhtmlcs.txt

@dimb
Copy link
Contributor Author

dimb commented Apr 19, 2018

@podarok There are no changes in the existing features files. Only new config files were created and the changes in the migrations were added to make /locations page in a two columns layout and add an amenities filter to the demo content. So there is nothing to worry about related to the upgrade path.

@gundevel
Copy link
Collaborator

Build comment file:

Environment Link
Fresh OpenY installation http://openy.cibox.tools/build283
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build283
Installation process http://install.openy-dev.ffwua.com/build283/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/283/

@gundevel
Copy link
Collaborator

Acessibility Sniffer: front page checking WCAG2AA http://ci.openymca.org/build283/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://ci.openymca.org/build283/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://ci.openymca.org/build283/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://ci.openymca.org/build283/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://ci.openymca.org/build283/blogWCAG2AAhtmlcs.txt

Copy link
Contributor

@podarok podarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fix

@@ -154,6 +154,7 @@ dependencies:
- openy_prgf_blog_listing
- openy_prgf_block_date
- openy_prgf_loc_finder
- openy_prgf_location_by_amenities
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend openy.install with hook_update_N and enable this module from there, please @kolesnikoff

@gundevel
Copy link
Collaborator

Build comment file:

Environment Link
Fresh OpenY installation http://openy.cibox.tools/build293
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build293
Installation process http://install.openy-dev.ffwua.com/build293/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/293/

@@ -741,7 +741,7 @@ function openy_update_8050() {
/**
* Enable CSS Editor module and import the settings.
*/
function openy_update_8050() {
function openy_update_8051() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@podarok Dmitriy has fixed this number because I missed it during the merge of CSS Editor module. Now all numbers are correct.

@gundevel
Copy link
Collaborator

Acessibility Sniffer: front page checking WCAG2AA http://ci.openymca.org/build293/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://ci.openymca.org/build293/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://ci.openymca.org/build293/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://ci.openymca.org/build293/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://ci.openymca.org/build293/blogWCAG2AAhtmlcs.txt

@ymcatwincities ymcatwincities deleted a comment from gundevel Apr 24, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Apr 24, 2018
@podarok podarok merged commit 54fc81f into ymcatwincities:8.x-1.x Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Level: Middle Needs skilled developer to work on PR: Needs Work Unfinished task. Issues still there Status: Needs work Unfinished task. Issues still there Type: Enhancement Change request. New functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants