This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
[OYPD-182] Full width image for subcategory list below 480px #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@david-hernandez let's center image on screen 480px-768px without max-width. |
Sanchiz
added
PR: Code Reviewed
Build comment file:=============== Test PASSed. |
|
Behat test results file URL: http://openy-dev.ffwua.com/build443/profiles/openy/build/reports/behat |
hamrant
pushed a commit
to hamrant/openy
that referenced
this pull request
Feb 16, 2017
[OYPD-182] Full width image for subcategory list below 480px
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to center the image between 480 and 760, but I wouldnt make the image max width. It will expand a 270px image to fit 700+ width which will look bad.