Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Activity Finder 2.0 #1661

Merged
merged 50 commits into from Jul 22, 2019
Merged

Activity Finder 2.0 #1661

merged 50 commits into from Jul 22, 2019

Conversation

jediandrey
Copy link
Collaborator

Original Issue, this PR is going to fix: REPLACE WITH A LINK TO ISSUE ( publicly available )

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 8.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

  • Please provide steps for review here.
  • Please provide steps for review here.
  • Please provide steps for review here.
  • Please provide steps for review here.

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
    CI code sniffer errors
  • All tests are running and there are no failed tests reported by CI.
    Behat test results
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

jediandrey and others added 30 commits June 4, 2019 16:38
@jediandrey
[OS-452] AF: apply new design changes to results teaser and program m…
8aa9f13 
…odal
@anpolimus
Temporare moved to dev version of Vue.js
2e22696
@anpolimus
Separated monolitic app into Vue components
40b8022
@anpolimus
Changed general AF template
6620c73
@anpolimus
Merge branch 'dev-8.x-2.x-activity-finder' of github.com:jediandrey/o…
e288e17 
…peny into dev-8.x-2.x-activity-finder

# Conflicts:
#	modules/custom/openy_activity_finder/templates/openy-activity-finder-program-search.html.twig
@jediandrey
[OS-452] AF: apply new design changes to results teaser and program m…
a8a294f 
…odal
@jediandrey
merge
39f686f
@jediandrey
Merge pull request #5 from anpolimus/dev-8.x-2.x-activity-finder
77ea6f0 
Dev 8.x 2.x activity finder
@jediandrey
AF: remove unnecessary files
e326d61
@jediandrey
AF: refactor Activity finder to vue components structure
b5e1d0e
@ygerasimov
Filter as separate component. Works with Ages step.
66ff4ed
@ygerasimov
Use Filter component for all three steps: Age, Day, Activity.
3f236fe
@jediandrey
Merge pull request #6 from ygerasimov/filter-component
659aa3a 
Filter as separate component. Works with all steps
@jediandrey
AF: add new theming for mobile-tablet-desktop
1f23e6b
@jediandrey
Merge branch 'dev-8.x-2.x-af20' of https://github.com/jediandrey/openy …
847d4e5 
…into dev-8.x-2.x-af20
@jediandrey
Activity Finder: update theming, implement new step filters logic
065e2d4
@ygerasimov
Implement Daxko AF steps.
c9308f0
@jediandrey
Merge pull request #7 from ygerasimov/daxko-activity-step
26b0d18 
Implement Daxko AF steps.
@ygerasimov
AF: Initiate state. Back button.
ec230f8
@ygerasimov
AF: Remove debug code.
7951d05
@jediandrey
AF: apply style changes to Daxko
be83644
@jediandrey
AF: add combined field for search by min max ages
ce30553
@jediandrey
Merge pull request #8 from ygerasimov/af-init-step-back
88c8f95 
AF: Initiate state. Back button.
@jediandrey
Merge branch 'dev-8.x-2.x-af20' of https://github.com/jediandrey/openy …
feed6ab 
…into dev-8.x-2.x-af20
@jediandrey
AF: add exclude, limit functionality, various important fixes
1a672cb
@jediandrey
AF: cleanup
592fc61
@jediandrey
modules/custom/openy_activity_finder/config/optional/search_api.index…
8821870 
….default.yml

AF: update configs
@jediandrey
AF: improve ages search processor, etc
a819c3d
@jediandrey
AF: update main.js
a50631d
@anpolimus
Deleted old AF file, since we moved to the webpack approach.
d08ec6d
@jediandrey jediandrey requested a review from podarok July 18, 2019 10:31
@jediandrey jediandrey changed the title Dev 8.x 2.x af20 Activity Finder 2.0 Jul 18, 2019
@ymcatwincities ymcatwincities deleted a comment from gundevel Jul 18, 2019
@podarok
Copy link
Contributor

podarok commented Jul 18, 2019

retest this please

@podarok podarok requested a review from danylevskyi July 18, 2019 11:47
@ymcatwincities ymcatwincities deleted a comment from gundevel Jul 18, 2019
@gundevel
Copy link
Collaborator

Build comment file:

Environment Link
Fresh OpenY installation - Rose theme http://openy.cibox.tools/build1671
Fresh OpenY installation - Lily theme http://lily.openy.cibox.tools/build1671
Upgraded(upgrade path) installation http://upgrade.openy.cibox.tools/build1671
Installation process http://install.openy.cibox.tools/build1671/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/1671/

@gundevel
Copy link
Collaborator

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build1671/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build1671/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build1671/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build1671/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build1671/blogWCAG2AAhtmlcs.txt

@gundevel
Copy link
Collaborator

Build comment file:

Environment Link
Fresh OpenY installation - Rose theme http://openy.cibox.tools/build1673
Fresh OpenY installation - Lily theme http://lily.openy.cibox.tools/build1673
Upgraded(upgrade path) installation http://upgrade.openy.cibox.tools/build1673
Installation process http://install.openy.cibox.tools/build1673/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/1673/

@gundevel
Copy link
Collaborator

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build1673/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build1673/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build1673/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build1673/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build1673/blogWCAG2AAhtmlcs.txt

@gundevel
Copy link
Collaborator

Build comment file:

Environment Link
Fresh OpenY installation - Rose theme http://openy.cibox.tools/build1674
Fresh OpenY installation - Lily theme http://lily.openy.cibox.tools/build1674
Upgraded(upgrade path) installation http://upgrade.openy.cibox.tools/build1674
Installation process http://install.openy.cibox.tools/build1674/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/1674/

podarok
podarok suggested changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@podarok podarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small thing to fix, please

modules/custom/openy_activity_finder/openy_af_vue_app/components/LocationStep.vue Outdated Show resolved Hide resolved
modules/custom/openy_activity_finder/openy_af_vue_app/components/LocationStep.vue Outdated Show resolved Hide resolved
modules/custom/openy_activity_finder/openy_af_vue_app/package.json Outdated Show resolved Hide resolved
modules/custom/openy_activity_finder/src/Plugin/Block/ActivityFinderBlock.php Show resolved Hide resolved
modules/custom/openy_activity_finder/src/Plugin/Block/ActivityFinderBlock.php Outdated Show resolved Hide resolved
@ymcatwincities ymcatwincities deleted a comment from gundevel Jul 19, 2019
@gundevel
Copy link
Collaborator

Build comment file:

Environment Link
Fresh OpenY installation - Rose theme http://openy.cibox.tools/build1675
Fresh OpenY installation - Lily theme http://lily.openy.cibox.tools/build1675
Upgraded(upgrade path) installation http://upgrade.openy.cibox.tools/build1675
Installation process http://install.openy.cibox.tools/build1675/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/1675/

@podarok podarok merged commit e00273c into ymcatwincities:8.x-2.x Jul 22, 2019
@podarok
Copy link
Contributor

podarok commented Jul 22, 2019

Well done @atiupa @jediandrey

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndreyMaximov AndreyMaximov AndreyMaximov left review comments

@podarok podarok podarok approved these changes

@danylevskyi danylevskyi Awaiting requested review from danylevskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jediandrey @podarok @gundevel @AndreyMaximov @anpolimus @ygerasimov