Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[INOYI-13] Location Finder: map marker popups have gray border. #1965

Merged
merged 1 commit into from Mar 25, 2020

Conversation

manachynskyi
Copy link
Contributor

This PR is going to fix gray border in carnation theme in Map marker popups.
Carnation:
http://i.imgur.com/wZw0KZ7.png
Rose:
http://i.imgur.com/4SKc7RC.png

Steps for review

  • log in as admin -> set Carnation as default theme /admin/appearance
  • visit /locations
  • click on any location marker
  • make sure that marker popup don't have gray border.

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@ghost
Copy link

ghost commented Mar 24, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.318 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@hamrant hamrant added Five Jars Assigned for resolution PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed Type: Bug Bug. Something is not working as intended. labels Mar 25, 2020
@hamrant hamrant requested review from afi13 and podarok March 25, 2020 08:24
@podarok podarok merged commit 09c2ed1 into ymcatwincities:8.x-2.x Mar 25, 2020
@manachynskyi manachynskyi deleted the INOYI-13 branch August 25, 2020 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Five Jars Assigned for resolution PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants