Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[YGO-24] Carnation theme fixes for event page #1985

Merged
merged 5 commits into from Apr 6, 2020
Merged

[YGO-24] Carnation theme fixes for event page #1985

merged 5 commits into from Apr 6, 2020

Conversation

anprok
Copy link
Contributor

@anprok anprok commented Apr 2, 2020

image
example of buggy page https://sandbox-carnation-cus.openy.org/events/ymca-event
TODO
Remove timezone and change date format to Apr 14, 10:45 pm - Apr 14, 11:45 pm
(it was fixed globally in module but left in Carnation theme template)
Add space between icon and Contact information label.

Steps for review

  • login as admin
  • visit Appearance page and switch to Carnation theme
  • open page events/ymca-event
  • make sure that start/end date format is correct
  • make sure that added space between icon and Contact information label

dchubar-fj
dchubar-fj previously approved these changes Apr 2, 2020
@dchubar-fj
Copy link
Contributor

retest this please

@gundevel
Copy link
Collaborator

gundevel commented Apr 2, 2020

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2149/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2149/

@anprok anprok changed the title {YGO-24] Carnation theme fixes for event page [YGO-24] Carnation theme fixes for event page Apr 2, 2020
@gundevel
Copy link
Collaborator

gundevel commented Apr 2, 2020

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2150/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2150/

@gundevel
Copy link
Collaborator

gundevel commented Apr 2, 2020

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2150/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build2150/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build2150/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build2150/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build2150/blogWCAG2AAhtmlcs.txt

@gundevel
Copy link
Collaborator

gundevel commented Apr 2, 2020

Open Y Complete profile installed at http://openy.cibox.tools/build2149/

@gundevel
Copy link
Collaborator

gundevel commented Apr 2, 2020

Open Y Complete profile installed at http://openy.cibox.tools/build2150/

@ghost
Copy link

ghost commented Apr 3, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.001 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

podarok
podarok previously approved these changes Apr 6, 2020
@podarok podarok dismissed stale reviews from dchubar-fj and themself via a952311 April 6, 2020 09:59
@podarok podarok added Five Jars Assigned for resolution Level: Middle Needs skilled developer to work on PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed Type: Bug Bug. Something is not working as intended. labels Apr 6, 2020
@podarok podarok merged commit 830efa9 into ymcatwincities:8.x-2.x Apr 6, 2020
@anprok anprok deleted the YGO-24 branch May 19, 2020 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Five Jars Assigned for resolution Level: Middle Needs skilled developer to work on PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants