Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[YGO-194] Fix menu attributes issue. #2124

Merged
merged 2 commits into from Aug 31, 2020

Conversation

manachynskyi
Copy link
Contributor

This PR is going to fix issue with missed 'target', 'rel', 'class' attributes that are available in "Link (with attributes)" Link field widget.

Steps for review

  • visit Main navigation menu /admin/structure/menu/manage/main
  • edit any menu item
  • set 'target', 'rel', 'class' https://i.imgur.com/zSt2ci6.png
  • open homepage
  • make sure that attributes added to menu link https://i.imgur.com/vYlWjFx.png
  • repeat the same for User account menu
    P.S. As User account menu not configured (in current realization of configs and template) to display 2 level links, this condition was removed.

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok
Copy link
Contributor

podarok commented Aug 31, 2020

ok to test

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2454/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2454/

@gundevel
Copy link
Collaborator

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2454/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build2454/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build2454/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build2454/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build2454/blogWCAG2AAhtmlcs.txt

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build2454/

@gundevel
Copy link
Collaborator

Open Y Complete profile installed at http://openy.cibox.tools/build2454/

@podarok podarok merged commit c5d911a into ymcatwincities:8.x-2.x Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants