[CR-21] Update simple_menu_icons to 8.x-2.x

[AndreyMaximov]

Original Issue, this PR is going to fix: #2080

Steps for review

• verify compose checkouts simple_menu_icon:8.x-2.x and the patch applies well
• login as admin
• edit any menu's top-level menu item (e.g. main menu's menu item)
• upload an image using the Icon image field provided by the simple_menu_icons module
• save the menu item
• verify the site is not crashing
• verify a file menu_icons_###########.css created at public://css (depends on your setup, but usually it's sites/default/files/css):
  • the file contents should be similar to following:

  .menu-icon-7 .section-icon {
    background-image: url(/sites/lily/files/menu_icons/image.png);
  }

• go to the home page
• find the edited menu item
• add the <div class="section-icon"></div> markup under the .menu-icon-7 element and verify the CSS is included on the page

[gundevel]

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2579/install.php

---

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2579/

[gundevel]

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2579/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build2579/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build2579/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build2579/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build2579/blogWCAG2AAhtmlcs.txt

[gundevel]

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build2579/

[podarok]

RuntimeException: Recursive router rebuild detected. in                  [error]
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/lib/Drupal/Core/Routing/RouteBuilder.php:121
Stack trace:
#0
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/lib/Drupal/Core/ProxyClass/Routing/RouteBuilder.php(83):
Drupal\Core\Routing\RouteBuilder->rebuild()
#1
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/lib/Drupal/Core/Extension/ModuleInstaller.php(344):
Drupal\Core\ProxyClass\Routing\RouteBuilder->rebuild()
#2
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php(83):
Drupal\Core\Extension\ModuleInstaller->install(Array, false)
#3
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/includes/install.core.inc(1882):
Drupal\Core\ProxyClass\Extension\ModuleInstaller->install(Array,
false)
#4
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/includes/batch.inc(295):
_install_module_batch('openy_menu_main', 'Open Y Menu Mai...', Array)
#5
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/includes/form.inc(947):
_batch_process()
#6
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/includes/install.core.inc(652):
batch_process(Object(Drupal\Core\Url), Object(Drupal\Core\Url))
#7
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/includes/install.core.inc(570):
install_run_task(Array, Array)
#8
/var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/core/includes/install.core.inc(118):
install_run_tasks(Array, NULL)
#9 phar:///usr/local/bin/drush/includes/drush.inc(728):
install_drupal(Object(Composer\Autoload\ClassLoader), Array)
#10 phar:///usr/local/bin/drush/includes/drush.inc(713):
drush_call_user_func_array('install_drupal', Array)
#11
phar:///usr/local/bin/drush/commands/core/drupal/site_install.inc(82):
drush_op('install_drupal', Object(Composer\Autoload\ClassLoader),
Array)
#12
phar:///usr/local/bin/drush/commands/core/site_install.drush.inc(271):
drush_core_site_install_version('openy', Array)
#13 phar:///usr/local/bin/drush/includes/command.inc(422):
drush_core_site_install('openy', 'openy_theme_sel...',
'openy_terms_of_...', 'install_configu...')
#14 phar:///usr/local/bin/drush/includes/command.inc(231):
_drush_invoke_hooks(Array, Array)
#15 phar:///usr/local/bin/drush/includes/command.inc(199):
drush_command('openy', 'openy_theme_sel...', 'openy_terms_of_...',
'install_configu...')
#16 phar:///usr/local/bin/drush/lib/Drush/Boot/BaseBoot.php(67):
drush_dispatch(Array)
#17 phar:///usr/local/bin/drush/includes/preflight.inc(67):
Drush\Boot\BaseBoot->bootstrap_and_dispatch()
#18 phar:///usr/local/bin/drush/includes/startup.inc(465):
drush_main()
#19 phar:///usr/local/bin/drush/includes/startup.inc(369):
drush_run_main(false, '/', 'Phar detected. ...')
#20 phar:///usr/local/bin/drush/drush(114): drush_startup(Array)
#21 /usr/local/bin/drush(10): require('phar:///usr/loc...')
#22 {main}
stdout: You are about to create a /var/lib/jenkins/jobs/PR_BUILDER_COMPOSER/workspace/build2579/openy-project/docroot/sites/default/settings.php file and DROP all tables in your 'drupal2579' database. Do you want to continue? (y/n): y

Failed for the first time. Restarting

[podarok]

retest this please

[gundevel]

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2580/install.php

---

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2580/

[gundevel]

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2580/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build2580/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build2580/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build2580/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build2580/blogWCAG2AAhtmlcs.txt

[gundevel]

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build2580/

[gundevel]

Open Y Complete profile installed at http://openy.cibox.tools/build2580/

[podarok]

Great
It does work