-
Notifications
You must be signed in to change notification settings - Fork 111
[CR-18] Remove dependencies to media_entity_video, switch to core video media #2189
Conversation
...atures/openy_media/modules/openy_media_local_video/config/install/media.type.video_local.yml
Show resolved
Hide resolved
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2586/install.php Test PASSed. |
Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2586/frontWCAG2AAhtmlcs.txt |
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build2586/ |
retest this please |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2587/install.php Test PASSed. |
Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2587/frontWCAG2AAhtmlcs.txt |
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build2587/ |
retest this please |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2589/install.php Test PASSed. |
Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build2589/frontWCAG2AAhtmlcs.txt |
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build2589/ |
Open Y Complete profile installed at http://openy.cibox.tools/build2589/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!!!
Let's wait for the rest of the guys to respond and we are ready to merge
@AndreyMaximov feel free to remove media_entity_video in 9.x-2.x branch accordingly to this PR |
This will be merged into next point release after upcoming one Thanks to all parties |
https://www.drupal.org/project/media_entity_video/releases/8.x-3.0-alpha1 @AndreyMaximov @hamrant release is there. Upgrade hook also is written. We could proceed with the removal and migrate to the core for the February release |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2765/install.php Test PASSed. |
Open Y Complete profile installed at http://openy.cibox.tools/build2765/ |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2768/install.php Test PASSed. |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2769/install.php Test PASSed. |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2770/install.php Test PASSed. |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2771/install.php Test PASSed. |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2772/install.php Test PASSed. |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2773/install.php Test PASSed. |
Open Y Complete profile installed at http://openy.cibox.tools/build2768/ |
!!! Couldn't read comment file !!! Build Log
|
Open Y Complete profile installed at http://openy.cibox.tools/build2769/ |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2777/install.php Test PASSed. |
Open Y Complete profile installed at http://openy.cibox.tools/build2770/ |
!!! Couldn't read comment file !!! Build Log
|
Open Y Complete profile installed at http://openy.cibox.tools/build2771/ |
!!! Couldn't read comment file !!! Build Log
|
Original Issue, this PR is going to fix: #2183
Steps for review
/admin/structure/media/manage/video_local
)Media source
field indicatesVideo file
If the
Media source
field is showingVideo
instead ofVideo file
, the upgrade didn't go well.Media source
prior to this PR:media_ modules overview
There are following
media_
modules in Open Y:The way to deprecate modules: