Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Remove media_entity_document because it is not used by Open Y. We migrated to core media #2359

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

podarok
Copy link
Contributor

@podarok podarok commented Jan 5, 2021

See https://github.com/ymcatwincities/openy/wiki/Important-versions-for-upgrade-path

media_ modules overview

There are following media_ modules in Open Y:

  • media_directories - this is a module that provides Media Library browser thing, should be kept untouched;
  • media_entity - legacy media_entity module, moved to Drupal Core, left in composer.json as a dependency for the Upgrade path from Open Y 1.x;
  • media_entity_document - is not used by Open Y anymore, left in composer.json as a dependency for the Upgrade path from Open Y 1.x.
  • media_entity_image - is not used by Open Y anymore, left here for the Upgrade path from Open Y 1.x;
  • media_entity_video - this is a module in use. There are a couple of issues to resolve to get rid of the module: fix d9 compatibility, migrate to Drupal Core media - both addressed in this PR. The module can be marked as deprecated in the release note. Should be kept in composer.json for the Upgrade path from Open Y 1.x.

Original Issue, this PR is going to fix: remove not used module in Q2 2021

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

  • Check before this PR module is disabled
    image

  • Verify media_entity_document module not being pulled by composer.

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@podarok podarok added PR: DO NOT MERGE Work in Progress or something not to be merged at all Type: Task Maintenance, subtasks Severity: Important High priority issue. dependencies Issues with dependencies labels Jan 5, 2021
@podarok podarok added this to the Q2 release 2021 milestone Jan 5, 2021
@podarok podarok self-assigned this Jan 5, 2021
@gundevel
Copy link
Collaborator

gundevel commented Jan 5, 2021

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build2926/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/2926/

@gundevel
Copy link
Collaborator

gundevel commented Jan 5, 2021

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build2926/

@gundevel
Copy link
Collaborator

gundevel commented Jan 5, 2021

Open Y Complete profile installed at http://openy.cibox.tools/build2926/

@podarok podarok added the PR: Tested Manually tested. Green light for merging label Jan 5, 2021
@podarok
Copy link
Contributor Author

podarok commented Jan 5, 2021

image

@hamrant hamrant added the PR: Code Reviewed Code reviewed. Ready for QA label Jan 5, 2021
Copy link
Contributor Author

@podarok podarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for @duozersk

composer.json Show resolved Hide resolved
@podarok podarok changed the base branch from 9.x-3.x to 9.x-2.x-Q3release May 19, 2021 09:47
@podarok podarok mentioned this pull request May 19, 2021
7 tasks
@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3185/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3185/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3185/

@podarok podarok changed the base branch from 9.x-2.x-Q3release to 9.x-2.x June 22, 2021 10:01
@podarok podarok merged commit 468e0d1 into 9.x-2.x Jun 22, 2021
@podarok podarok deleted the 9.x-3.x-media_entity_document_cleanup branch June 22, 2021 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issues with dependencies PR: Code Reviewed Code reviewed. Ready for QA PR: DO NOT MERGE Work in Progress or something not to be merged at all PR: Tested Manually tested. Green light for merging Severity: Important High priority issue. Type: Task Maintenance, subtasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants