Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add update_path. Move menu to openy_gxp. Make it main in suite. #2412

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

podarok
Copy link
Contributor

@podarok podarok commented Feb 24, 2021

Original Issue, this PR is going to fix: https://openy.atlassian.net/browse/MAINTAIN-51

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

  • Check /admin/openy/integrations/groupex-pro is in place when openy_gxp module enabled.
  • Verify both Install and Upgrade.
  • check dependencies now from openy_gxp for all submodules
    image

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@podarok podarok self-assigned this Feb 24, 2021
@podarok podarok requested a review from hamrant February 24, 2021 12:24
@podarok podarok added Daxko Related to Daxko integration dependencies Issues with dependencies Level: Advanced Complex task. Usually for Core team PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed Severity: Minor Backlog Type: Task Maintenance, subtasks Type: Bug Bug. Something is not working as intended. labels Feb 24, 2021
@podarok
Copy link
Contributor Author

podarok commented Feb 24, 2021

retest this please

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3103/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3103/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3103/

@gundevel
Copy link
Collaborator

Open Y Complete profile installed at http://openy.cibox.tools/build3103/

@ymcatwincities ymcatwincities deleted a comment from gundevel Feb 24, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel Feb 24, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel Feb 24, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel Feb 24, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel Feb 24, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel Feb 24, 2021
Copy link
Contributor

@hamrant hamrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok

@hamrant hamrant added PR: Code Reviewed Code reviewed. Ready for QA and removed PR: Needs Review Needs someone review ( code ) labels Feb 24, 2021
@hamrant
Copy link
Contributor

hamrant commented Feb 24, 2021

Tested on http://upgrade.openy.cibox.tools/build3103 - works as expected!

@hamrant hamrant added PR: Tested Manually tested. Green light for merging and removed PR: Needs Testing Manual testing is needed labels Feb 24, 2021
@podarok podarok merged commit 8219b5a into 9.x-2.x Feb 24, 2021
@podarok podarok deleted the 9.x-2.x-gxp_menu branch February 24, 2021 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Daxko Related to Daxko integration dependencies Issues with dependencies Level: Advanced Complex task. Usually for Core team PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging Severity: Minor Backlog Type: Bug Bug. Something is not working as intended. Type: Task Maintenance, subtasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants