Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[PRODDEV-240] Display search input field for the lily theme, backport… #2420

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

NightHunterSV
Copy link
Contributor

… it's styling from the rose theme

Original Issue, this PR is going to fix: https://openy.atlassian.net/browse/PRODDEV-240

Thank you for your contribution!

@gundevel
Copy link
Collaborator

gundevel commented Mar 3, 2021

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

Copy link
Contributor

@hamrant hamrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok

@hamrant hamrant added Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed labels Mar 4, 2021
@hamrant
Copy link
Contributor

hamrant commented Mar 4, 2021

ok to test

@gundevel
Copy link
Collaborator

gundevel commented Mar 4, 2021

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3118/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3118/

@gundevel
Copy link
Collaborator

gundevel commented Mar 4, 2021

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3118/

@gundevel
Copy link
Collaborator

gundevel commented Mar 4, 2021

Open Y Complete profile installed at http://openy.cibox.tools/build3118/

@hamrant
Copy link
Contributor

hamrant commented Mar 4, 2021

Tested on the VY - fivejars/openy_gated_content#229 (comment)

@hamrant hamrant requested a review from podarok March 4, 2021 15:10
@hamrant hamrant added PR: Tested Manually tested. Green light for merging and removed PR: Needs Testing Manual testing is needed labels Mar 4, 2021
@podarok
Copy link
Contributor

podarok commented Mar 4, 2021

We are not accepting fixes to Drupal 8 branch, unless there is a critical fix we must to push as a hotfix , approved by @sarah-halby .
If it's not critical - let's use 9.x-2.x as a base branch @hamrant @NightHunterSV

Copy link
Contributor

@podarok podarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change base to 9.x-2.x

@podarok podarok changed the base branch from 8.x-2.x to 9.x-2.x March 5, 2021 12:37
@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3119/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3119/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3119/

@hamrant hamrant requested a review from podarok March 16, 2021 08:50
@podarok podarok merged commit 7f01e9a into ymcatwincities:9.x-2.x Mar 16, 2021
@hamrant hamrant deleted the PRODDEV-240 branch March 16, 2021 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants