Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[MAINTAIN-10] fixed a white background for local video in Safari browser #2422

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Conversation

aleevas
Copy link
Contributor

@aleevas aleevas commented Mar 15, 2021

Original Issue, this PR is going to fix: #1164
Jira issue MAINTAIN-10

This one should fix white background for Location Video on Safari browser for all 3 themes.
How it looks before this fix:
Rose:
MAINTAIN-10-RoseBefore
Lily:
MAINTAIN-10-LilyBefore

Carnation:
MAINTAIN-10-CarantionBefore

How it should looks after fix:
Rose:
MAINTAIN-10-fixedRose

Lily:
MAINTAIN-10-fixedLily

Carnation:
MAINTAIN-10-fixedCarnation

Steps for review

  • log as admin.
  • create a new Landing page (Please fiil all fields: Title, Layout->One Column)
  • in Content Area pleas add a new Simple content paragraph
  • in this paragraph please add a new media entty Local video
    MAINTAIN-10-addLocalVideo
  • save and check on Safari browser
  • Go to the /admin/appearance page
  • change theme and check for new theme

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

Copy link
Contributor

@hamrant hamrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok

@hamrant hamrant marked this pull request as ready for review March 15, 2021 14:10
@hamrant
Copy link
Contributor

hamrant commented Mar 15, 2021

ok to test

@hamrant hamrant added Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed labels Mar 15, 2021
@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3120/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3120/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3120/

@hamrant hamrant added PR: Tested Manually tested. Green light for merging and removed PR: Needs Testing Manual testing is needed labels Mar 15, 2021
@ekaterina-samuseva
Copy link

Fix was checked on iPhone 11 Pro, iOS 14.1, Safari
Page with added local video: http://upgrade.openy.cibox.tools/build3120/ekaterina-test
image
image
image

@hamrant hamrant requested a review from podarok March 15, 2021 15:00
@podarok podarok merged commit 06c584a into ymcatwincities:9.x-2.x Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local video player doesn't have border on table
5 participants