Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Bug Fix. Add jquery_ui_touch_punch #2449

Merged
merged 4 commits into from
May 17, 2021
Merged

Bug Fix. Add jquery_ui_touch_punch #2449

merged 4 commits into from
May 17, 2021

Conversation

podarok
Copy link
Contributor

@podarok podarok commented May 17, 2021

Original Issue, this PR is going to fix: There is no way to proceed with Database Upgrade via Browser due to library is missing
image
See https://www.drupal.org/project/jquery_ui_touch_punch/issues/3159222#comment-14105221

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

  • Check Reports status page contains no error about jQuery UI Punch library missed
  • Check update.php has no error and does not block from running the upgrade.
    image

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@podarok podarok added Type: Bug Bug. Something is not working as intended. dependencies Issues with dependencies labels May 17, 2021
@podarok podarok self-assigned this May 17, 2021
@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3180/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3180/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3180/

@podarok podarok requested a review from hamrant May 17, 2021 09:47
@ymcatwincities ymcatwincities deleted a comment from gundevel May 17, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel May 17, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel May 17, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel May 17, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel May 17, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel May 17, 2021
Copy link
Contributor

@hamrant hamrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me

@hamrant hamrant added PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging labels May 17, 2021
@podarok podarok changed the title Add jquery_ui_touch_punch Bug Fix. Add jquery_ui_touch_punch May 17, 2021
@podarok podarok merged commit b49d376 into 9.x-2.x May 17, 2021
@podarok podarok deleted the jquery_ui_touch_punch branch May 17, 2021 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issues with dependencies PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants