Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[MAINTAIN-8] added aria-hidden attribute to 'Add to calendar' link for GroupEx schedule table for all three themes #2460

Merged
merged 1 commit into from
May 27, 2021

Conversation

aleevas
Copy link
Contributor

@aleevas aleevas commented May 26, 2021

Original Issue, this PR is going to fix: MAINTAIN-8 and #898

As was suggested in Jirra issue description i added the aria-hidden attribute for 'Add to caelendar' link in GroupEx schedule page for all three themes

Steps for review

  • go to /schedules/group-schedules?location=4435

  • Given I have VoiceOver enabled

  • When I follow to the icon
    33821368-3b77f0b0-de5c-11e7-98fd-37d1fca351dc

  • screen reader should skip this link

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

…r GroupEx schedule table for all three themes
@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@hamrant hamrant marked this pull request as ready for review May 26, 2021 12:48
@hamrant hamrant requested a review from podarok May 26, 2021 12:48
@hamrant hamrant added Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed labels May 26, 2021
@hamrant
Copy link
Contributor

hamrant commented May 26, 2021

ok to test

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3193/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3193/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3193/

@podarok podarok merged commit 40cabc3 into ymcatwincities:9.x-2.x May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants