-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3204/install.php Test PASSed. |
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3204/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we can remove everything related to this:
$this->schedule = $schedule;
return $this->schedule;
just return $schedule;
And remove
/**
* Cached schedule.
*
* @var array
*/
private $schedule = [];
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3205/install.php Test PASSed. |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3206/install.php Test PASSed. |
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3205/ |
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3206/ |
Original Issue, this PR is going to fix: #1928 + https://openy.atlassian.net/browse/MAINTAIN-20
Make sure these boxes are checked before asking for review of your pull request - thank you!
If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.
Steps for review
General checks
Thank you for your contribution!