Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Remove block which is not used #2464

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Remove block which is not used #2464

merged 3 commits into from
Jun 7, 2021

Conversation

podarok
Copy link
Contributor

@podarok podarok commented Jun 7, 2021

Original Issue, this PR is going to fix: #1928 + https://openy.atlassian.net/browse/MAINTAIN-20

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@podarok podarok self-assigned this Jun 7, 2021
@podarok podarok added Daxko Related to Daxko integration Level: Middle Needs skilled developer to work on Severity: Minor Backlog Type: Task Maintenance, subtasks labels Jun 7, 2021
@gundevel
Copy link
Collaborator

gundevel commented Jun 7, 2021

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3204/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3204/

@gundevel
Copy link
Collaborator

gundevel commented Jun 7, 2021

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3204/

Copy link
Contributor

@hamrant hamrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we can remove everything related to this:

$this->schedule = $schedule;
return $this->schedule;

just return $schedule;

And remove

  /**
   * Cached schedule.
   *
   * @var array
   */
  private $schedule = [];

@hamrant hamrant added the PR: Code Reviewed Code reviewed. Ready for QA label Jun 7, 2021
@gundevel
Copy link
Collaborator

gundevel commented Jun 7, 2021

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3205/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3205/

@gundevel
Copy link
Collaborator

gundevel commented Jun 7, 2021

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3206/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3206/

@gundevel
Copy link
Collaborator

gundevel commented Jun 7, 2021

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3205/

@gundevel
Copy link
Collaborator

gundevel commented Jun 7, 2021

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3206/

@podarok podarok merged commit 6761e0f into 9.x-2.x Jun 7, 2021
@podarok podarok deleted the 9.x-2.x-cache_leftovers branch June 7, 2021 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Daxko Related to Daxko integration Level: Middle Needs skilled developer to work on PR: Code Reviewed Code reviewed. Ready for QA Severity: Minor Backlog Type: Task Maintenance, subtasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroupExScheduleFetcher cache not validated correctly
3 participants