Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix popper.js library missing #2476

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fix popper.js library missing #2476

merged 2 commits into from
Jun 29, 2021

Conversation

anpolimus
Copy link
Contributor

@anpolimus anpolimus commented Jun 17, 2021

2nd level of navigation was not working at Carnation. System was not able to find Poppeer.js library.

Steps for review

  • Open carnation on mobile.
  • Click on hamburger menu.
  • Check that you can open Programs menu

General checks

Thank you for your contribution!

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3215/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3215/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3215/

@anpolimus
Copy link
Contributor Author

@podarok is it possible to test it on a build?
I see that our build link returns 404

@podarok
Copy link
Contributor

podarok commented Jun 18, 2021

retest this please

@podarok
Copy link
Contributor

podarok commented Jun 18, 2021

@podarok is it possible to test it on a build?
I see that our build link returns 404

yes, sure. Builds are wiped out overnight or due to lack of space, so it's better to test at the same day or next day with asking bot to rebuild

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3216/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3216/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3216/

@podarok
Copy link
Contributor

podarok commented Jun 18, 2021

image

@anpolimus
Copy link
Contributor Author

@podarok yes we saw it at our project as well and were able to fix it in a subtheme.
Now I have to find a solution how to back port it.

@podarok
Copy link
Contributor

podarok commented Jun 18, 2021

popper is here
image

@podarok podarok added Backporting Requests to backport features from YMCAs to the Open Y Distribution IXM Assigned for resolution javascript Pull requests that update Javascript code Level: Middle Needs skilled developer to work on PR: Needs Work Unfinished task. Issues still there Type: Bug Bug. Something is not working as intended. labels Jun 22, 2021
Co-authored-by: NightHunterSV <nighthuntersv@gmail.com>
@podarok
Copy link
Contributor

podarok commented Jun 24, 2021

retest this please

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3239/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3239/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3239/

@podarok
Copy link
Contributor

podarok commented Jun 24, 2021

Seems like it does work
image
Have you faced with any issues due to upgraded version of dependency in the theme? @anpolimus @NightHunterSV

@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 24, 2021
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 24, 2021
@anpolimus
Copy link
Contributor Author

@podarok I've faced with it during the new build.
We are facing it at VY builds last time.
It looks like it came couple weeks ago.

@podarok podarok merged commit 89aa107 into 9.x-2.x Jun 29, 2021
@podarok podarok deleted the anpolimus-patch-1 branch June 29, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backporting Requests to backport features from YMCAs to the Open Y Distribution IXM Assigned for resolution javascript Pull requests that update Javascript code Level: Middle Needs skilled developer to work on PR: Needs Work Unfinished task. Issues still there Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants