-
Notifications
You must be signed in to change notification settings - Fork 111
Unlimited programs should be opened for users #2514
Conversation
// Daxko doesn't provide a number of available spots for unlimited offers. | ||
// But they should be open for users. | ||
if ($availability_status === 'open' && !$spots_available && !$limited) { | ||
$spots_available = 100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep this as a constant of the current class, please
@dchubar-fj could you put your description in module's readme.md? |
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3277/install.php Test PASSed. |
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3277/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
Let's improve readme a bit @dchubar-fj
Build comment file:Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3278/install.php Test PASSed. |
Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3278/ |
Problem/Motivation
Classes with an unlimited number of spots are displayed as completely filled in Activity Finder with the Daxko back-end. The root of the problem is that Open Y doesn't check the
limited
flag in the Daxko response. Daxko back-end relies on theavailable
field in the response:But unlimited classes don't have the
available
field:As result, unlimited classes are not available for registration in the Activity Finder, because the Register button is disabled
![Screenshot from 2021-07-08 18-12-46](https://user-images.githubusercontent.com/58946680/124947301-61d33280-e018-11eb-988d-93cb8faefe35.png)
![Screenshot from 2021-07-08 18-14-16](https://user-images.githubusercontent.com/58946680/124947415-7a434d00-e018-11eb-84ac-757a93dfb47e.png)
But they are open for registration in Daxko
Steps for review
General checks
Thank you for your contribution!