Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[MAINTAIN-155] fixed issue with not working modal dialog on membership (/join) page on Carnation theme #2544

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

aleevas
Copy link
Contributor

@aleevas aleevas commented Sep 9, 2021

Original Issue, this PR is going to fix: MAINTAIN-155

This one should fix issue with a modal window on /join page that didn't closing

MAINTAIN-155closeModal

Steps for review

  • go to /join page

  • please not check anything on page and click Next

  • verify that you can see the modal window with error message

  • verify that you can close it by clicking to x button
    MAINTAIN-155closeModal

  • please verify that you can close this modal window on every steps on this form

  • for additional check: go to /user/login

  • please fill fields with dummy credentials and click "Login"
    MAINTAIN-155closeModalOnAnotherPage

  • verify that you can see the modal window with error message

  • verify that you can close it

General checks

Thank you for your contribution!

@gundevel
Copy link
Collaborator

gundevel commented Sep 9, 2021

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@hamrant hamrant added Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed labels Sep 13, 2021
@hamrant hamrant marked this pull request as ready for review September 13, 2021 08:11
@hamrant
Copy link
Contributor

hamrant commented Sep 13, 2021

ok to test

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3414/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3414/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3414/

@hamrant
Copy link
Contributor

hamrant commented Sep 13, 2021

Looks ok for me - http://upgrade.openy.cibox.tools/build3414/join

@AnastasiiaPys
Copy link

AnastasiiaPys commented Sep 13, 2021

Tested on macOS(Chrome),Windows 10(Edge), Iphone 11, Ipad.

Works as expected.

@podarok podarok merged commit a692582 into ymcatwincities:9.x-2.x Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants