This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
[MAINTAIN-155] fixed issue with not working modal dialog on membership (/join) page on Carnation theme #2544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue, this PR is going to fix: MAINTAIN-155
This one should fix issue with a modal window on /join page that didn't closing
Steps for review
go to /join page
please not check anything on page and click Next
verify that you can see the modal window with error message
verify that you can close it by clicking to x button
![MAINTAIN-155closeModal](https://user-images.githubusercontent.com/744406/132727096-b0d63cb8-0c6c-4ddf-a843-eff360fa817e.png)
please verify that you can close this modal window on every steps on this form
for additional check: go to /user/login
please fill fields with dummy credentials and click "Login"
![MAINTAIN-155closeModalOnAnotherPage](https://user-images.githubusercontent.com/744406/132727082-523fd1f5-24fa-4a31-af8d-da4172ca8167.png)
verify that you can see the modal window with error message
verify that you can close it
General checks
Thank you for your contribution!