Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix parameters order in the implode for PHP 7.4 compatibility #2575

Conversation

NightHunterSV
Copy link
Contributor

@NightHunterSV NightHunterSV commented Oct 21, 2021

On one of the clients' projects we've noticed an error message about the deprecation of the order of the parameters used:

image

The site is currently on PHP 7.4, and there was deprecated the reverse order of parameters: https://www.php.net/manual/en/migration74.deprecated.php

Make sure these boxes are checked before asking for review of your pull request - thank you!

Steps for review

  • Run the build on PHP 7.4.
  • Go to some theme settings page.
  • Verify there are no error messages regarding the wrong parameters order on the implode call.

General checks

Thank you for your contribution!

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok podarok added Level: Middle Needs skilled developer to work on Type: Bug Bug. Something is not working as intended. labels Oct 21, 2021
@podarok podarok merged commit 16f4b81 into ymcatwincities:9.x-2.x Oct 21, 2021
@podarok
Copy link
Contributor

podarok commented Oct 21, 2021

@shelleygoetz @sarah-halby to include this into next point release, please

Thank you @NightHunterSV

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@sarah-halby
Copy link
Collaborator

@podarok to clarify, the next release on Nov 9 or the next point release in December?

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok
Copy link
Contributor

podarok commented Oct 21, 2021

@sarah-halby for next "any" release

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@shelleygoetz
Copy link
Collaborator

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Level: Middle Needs skilled developer to work on Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants