This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
[OYPD-377] Downgrade Plugin module from 2.5 to 2.4. Add dependencies for related paragraphs. #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed behat test is being resolved with #311. There was an Ansible error that resolved itself when retested. |
|
|
|
I've rebased on root/8.x-1.x I want to at least see that WYSIWYG error happen again because manual testing shows that iframe is still on the page when that icon is clicked. |
|
Tests pass after rebase. |
Kerby70
added
Status: Needs review
Sanchiz
added
PR: Needs Review
Sanchiz
suggested changes
May 3, 2017
| @@ -12,17 +12,17 @@ entity_type: paragraph | |||
| bundle: openy_prgf_mbrshp_calc | |||
| label: Block | |||
| description: '' | |||
| required: false | |||
| required: true | |||
Sanchiz
added
PR: Needs Work
…on\ArrayPluginDefinitionDecorator contains 1 abstract method and must therefore be declared abstract or implement the remaining methods
Build comment file:===============
Test PASSed. |
|
Behat test results file URL: http://openy-dev.ffwua.com/build1079/profiles/contrib/openy/build/reports/behat |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira https://propeople-us.atlassian.net/browse/OYPD-377
D.o https://www.drupal.org/node/2873442
Steps to review