Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[OYPD-358] Update class, adding header content, & bottom content. #331

Merged
merged 7 commits into from
May 10, 2017
Merged

[OYPD-358] Update class, adding header content, & bottom content. #331

merged 7 commits into from
May 10, 2017

Conversation

Kerby70
Copy link
Contributor

@Kerby70 Kerby70 commented May 3, 2017 •
edited by Sanchiz

Jira https://propeople-us.atlassian.net/browse/OYPD-358
D.o https://www.drupal.org/node/2875458

Steps to review

  • See class CT
    • has Header area with Header content field for paragraphs
    • has Bottom area with Bottom content field for paragraphs
    • When sidebar is empty the template does not render that area
    • Areas render in appropriate order.

Make sure these boxes are checked before asking for review of your pull request - thank you!

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
  • All tests are running and there are no failed tests reported by CI.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

Sanchiz
Sanchiz suggested changes May 4, 2017
View reviewed changes
modules/openy_features/openy_node/modules/openy_node_class/openy_node_class.install Outdated
/**
* Update class, adding header content, & bottom content.
*/
function openy_node_lcass_update_8002() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here. Should be openy_node_class_update_8002.

themes/openy_themes/openy_rose/templates/node/node--class--full.html.twig Outdated
{%
set content_classes = [
'class-content',
layout_class,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird indentation for twig arrays.

@Sanchiz Sanchiz added the PR: Needs Work Unfinished task. Issues still there label May 4, 2017
@Kerby70 Kerby70 mentioned this pull request May 4, 2017
Merged
4 tasks
@Kerby70 Kerby70 added PR: Needs Review Needs someone review ( code ) and removed PR: Needs Work Unfinished task. Issues still there labels May 4, 2017
@Sanchiz
Copy link
Contributor

Sanchiz commented May 5, 2017

  1. On the upgrade path environment "Bottom area" for the class looks different from other areas
    image

@Sanchiz Sanchiz added PR: Needs Work Unfinished task. Issues still there and removed PR: Needs Review Needs someone review ( code ) labels May 5, 2017
@Kerby70 Kerby70 added PR: Needs Review Needs someone review ( code ) PR: Needs Work Unfinished task. Issues still there and removed PR: Needs Work Unfinished task. Issues still there PR: Needs Review Needs someone review ( code ) labels May 8, 2017
@Kerby70 Kerby70 added PR: Needs Review Needs someone review ( code ) and removed PR: Needs Work Unfinished task. Issues still there labels May 9, 2017
@Sanchiz Sanchiz added this to the Version 1.2 milestone May 10, 2017
@gundevel
Copy link
Collaborator

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build1138
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build1138
Installation process http://install.openy-dev.ffwua.com/build1138/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/1138/

@Sanchiz Sanchiz modified the milestone: Version 1.2 May 10, 2017
@gundevel
Copy link
Collaborator

Behat test results file URL: http://ci.openymca.org/build1138/profiles/contrib/openy/build/reports/behat

Sanchiz
Sanchiz approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@Sanchiz Sanchiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Sanchiz Sanchiz merged commit b84775c into ymcatwincities:8.x-1.x May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sanchiz Sanchiz Sanchiz approved these changes

Assignees
No one assigned
Labels
PR: Needs Review Needs someone review ( code )
Projects
None yet
Milestone
Version 1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kerby70 @Sanchiz @gundevel