Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[OYPD-248] Fixing JS bugs in maps.js for zip code searching #332

Merged
merged 1 commit into from May 4, 2017

Conversation

david-hernandez
Copy link
Contributor

@david-hernandez david-hernandez commented May 3, 2017

The zip code search was not working at all when a zip code is entered into the box, under certain circumstances, because of a variable declaration error. We are using strict mode, so all variables have to be declared.

Also, the url paramater search does not work because the click() event was not identifying the button. The css classes on it changed.

  • Go to locations page, enter zip code to search. With default content, these work. 77001, 98108, 98115. Make sure the distance, and location type are changed to see if locations appear. The distance works by distance from center of zip code to location, not edge of zip code.
  • Verify the map changes and pin added when entering zip code and hitting enter on keyboard.
  • Verify the map changes and pin added when entering zip code and clicking the search button.
  • Verify url parameters work. Example, /locations?map_location=98059 . The map should get a pin automatically. When changing a filter, like distance, the map should update automatically.

@gundevel
Copy link
Collaborator

gundevel commented May 4, 2017

Build comment file:

===============

Environment Link
Fresh OpenY installation http://openy-dev.ffwua.com/build1083
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build1083
Installation process http://install.openy-dev.ffwua.com/build1083/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy-dev.ffwua.com:8080/job/PR_BUILDER/1083/

@gundevel
Copy link
Collaborator

gundevel commented May 4, 2017

Copy link
Contributor

@Sanchiz Sanchiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Sanchiz Sanchiz merged commit b27f3cf into ymcatwincities:8.x-1.x May 4, 2017
@Sanchiz Sanchiz mentioned this pull request May 4, 2017
@david-hernandez david-hernandez deleted the OYPD-248 branch July 20, 2017 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants