Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix fatal error #425

Merged
merged 1 commit into from Jun 2, 2017
Merged

Fix fatal error #425

merged 1 commit into from Jun 2, 2017

Conversation

hamrant
Copy link
Contributor

@hamrant hamrant commented Jun 1, 2017

Drupal.org issue - https://www.drupal.org/node/2883059

I got next error on my progect:
Fatal error: Call to a member function getType() on string in /var/www/docroot/profiles/contrib/openy/modules/openy_features/openy_location/modules/openy_loc_camp/openy_loc_camp.module on line 20

Short investigation show that in my case $node variable contain only ID.
Solution - add additional check that $node is instanceof NodeInterface.

@hamrant hamrant requested a review from Sanchiz June 1, 2017 14:33
@hamrant hamrant added PR: Needs Review Needs someone review ( code ) Type: Bug Bug. Something is not working as intended. labels Jun 1, 2017
@Sanchiz Sanchiz added this to the Version 1.2 milestone Jun 2, 2017
@gundevel
Copy link
Collaborator

gundevel commented Jun 2, 2017

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build1334
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build1334
Installation process http://install.openy-dev.ffwua.com/build1334/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/1334/

@gundevel
Copy link
Collaborator

gundevel commented Jun 2, 2017

Copy link
Contributor

@Sanchiz Sanchiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Sanchiz Sanchiz merged commit 40951fe into 8.x-1.x Jun 2, 2017
@Sanchiz Sanchiz deleted the YGS-653 branch June 2, 2017 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Needs Review Needs someone review ( code ) Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants