Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[OYPD-451] Update daxko, & opney_socrates, add openy_prgf_pgm_reg & openy_programs_search with configuration. #470

Merged
merged 74 commits into from Jun 22, 2017

Conversation

Kerby70
Copy link
Contributor

@Kerby70 Kerby70 commented Jun 8, 2017

Jira https://propeople-us.atlassian.net/browse/OYPD-451
D.o https://www.drupal.org/node/2884784

Make sure these boxes are checked before asking for review of your pull request - thank you!

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
    CI code sniffer errors
  • All tests are running and there are no failed tests reported by CI.
    Behat test results
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

Steps for review

  • As an admin configure connection to Daxko at /admin/config/services/daxko
  • Configure program registration configuration at /admin/config/services/daxko/programs-search
  • Add Program Registration paragraph to landing page
  • See Expected form on page.
  • Stepping through form results in the appropriate options & final link

@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 19, 2017
@Kerby70 Kerby70 added PR: Needs Review Needs someone review ( code ) and removed PR: Needs Work Unfinished task. Issues still there labels Jun 19, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 20, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 20, 2017
@Sanchiz
Copy link
Contributor

Sanchiz commented Jun 20, 2017

  1. Update password field from textfield to password field
    image

  2. Please convert to upper case
    image

  3. I've specified credentials for Daxko(see comment in JIRA ticket), but paragraph still doesn't work.
    Could you please provide credentials in JIRA ticket that work?

@Sanchiz Sanchiz added PR: Needs Work Unfinished task. Issues still there and removed PR: Needs Review Needs someone review ( code ) labels Jun 20, 2017
@Sanchiz Sanchiz added PR: Needs Review Needs someone review ( code ) and removed PR: Needs Work Unfinished task. Issues still there labels Jun 21, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 21, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 21, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 21, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 22, 2017
@Sanchiz Sanchiz added PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed and removed PR: Needs Review Needs someone review ( code ) labels Jun 22, 2017
@gundevel
Copy link
Collaborator

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build1690
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build1690
Installation process http://install.openy-dev.ffwua.com/build1690/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/1690/

@gundevel
Copy link
Collaborator

Decoupling report http://ci.openymca.org/build1690

@gundevel
Copy link
Collaborator

@Sanchiz Sanchiz merged commit 1f26d4b into ymcatwincities:8.x-1.x Jun 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants