Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix description in the module openy_block_basic #511

Merged
merged 2 commits into from
Jun 11, 2017
Merged

Fix description in the module openy_block_basic #511

merged 2 commits into from
Jun 11, 2017

Conversation

kristolukky
Copy link
Contributor

@kristolukky kristolukky commented Jun 11, 2017 •
edited by ddrozdik

Issue on drupal.org - https://www.drupal.org/node/2885219

Issue - #499

Steps for review:

  • Login as admin
  • Go to /admin/structure/block/block-content/manage/basic_block
  • Check that block description is exist
  • Go to /admin/structure/block/block-content/manage/basic_block/fields/block_content.basic_block.field_block_content
  • Check that field description is exist

@kristolukky kristolukky added PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Jun 11, 2017
@kristolukky kristolukky self-assigned this Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 11, 2017
@danylevskyi danylevskyi requested review from danylevskyi and hamrant and removed request for danylevskyi June 11, 2017 12:04
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from danylevskyi Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from danylevskyi Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from danylevskyi Jun 11, 2017
@Sanchiz Sanchiz added PR: Code Reviewed Code reviewed. Ready for QA and removed PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Jun 11, 2017
Sanchiz
Sanchiz approved these changes Jun 11, 2017
View reviewed changes
Copy link
Contributor

@Sanchiz Sanchiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@gundevel
Copy link
Collaborator

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build1447
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build1447
Installation process http://install.openy-dev.ffwua.com/build1447/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/1447/

@ddrozdik ddrozdik merged commit a91a1b3 into ymcatwincities:8.x-1.x Jun 11, 2017
@Sanchiz Sanchiz modified the milestone: Version 1.3 Jun 11, 2017
@Sanchiz Sanchiz mentioned this pull request Jun 11, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sanchiz Sanchiz Sanchiz approved these changes

@hamrant hamrant Awaiting requested review from hamrant

Assignees

@kristolukky kristolukky

Labels
PR: Code Reviewed Code reviewed. Ready for QA
Projects
No open projects
DrupalCamp Kyiv 2017 Code Sprint
Awaiting triage
Milestone
Version 1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kristolukky @gundevel @Sanchiz @ddrozdik