Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix description for landing_page.field_content.yml #520

Merged
merged 1 commit into from
Jun 11, 2017

Conversation

alex-poletaev
Copy link
Contributor

@alex-poletaev alex-poletaev commented Jun 11, 2017

Fixed description for field.field.node.landing_page.field_content.yml

Make sure these boxes are checked before asking for review of your pull request - thank you!

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
    CI code sniffer errors
  • All tests are running and there are no failed tests reported by CI.
    Behat test results
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

Steps for review

Open http://ci.openymca.org/build1449
1.Login as admin
2.Go to Administration -> Structure -> Content types -> Landing Page -> Manage Fields -> field_content -> Edit.
3.Check if Help text present

  • Please provide steps for review here.

Fixed description for field.field.node.landing_page.field_content.yml
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 11, 2017
Copy link
Contributor

@Sanchiz Sanchiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@Sanchiz Sanchiz added the PR: Code Reviewed Code reviewed. Ready for QA label Jun 11, 2017
@alex-poletaev alex-poletaev changed the title Fixed description Fix description for landing_page.field_content.yml Jun 11, 2017
@gundevel
Copy link
Collaborator

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build1449
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build1449
Installation process http://install.openy-dev.ffwua.com/build1449/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/1449/

@alex-poletaev
Copy link
Contributor Author

Steps for review:

  1. Open http://ci.openymca.org/build1449
  2. Login as admin
  3. Go to Administration -> Structure -> Content types -> Landing Page -> Manage Fields -> field_content -> Edit.
  4. Check if Help text present

@ddrozdik ddrozdik merged commit a5a4168 into 8.x-1.x Jun 11, 2017
@Sanchiz Sanchiz modified the milestone: Version 1.3 Jun 11, 2017
@Sanchiz Sanchiz deleted the alex-fix-description branch June 11, 2017 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Code Reviewed Code reviewed. Ready for QA
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants