Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

#508 Fix description in the module openy_node_alert #528

Merged
merged 5 commits into from Jun 11, 2017
Merged

#508 Fix description in the module openy_node_alert #528

merged 5 commits into from Jun 11, 2017

Conversation

andriibuda
Copy link
Contributor

@andriibuda andriibuda commented Jun 11, 2017 •
edited

Issue on drupal.org - https://www.drupal.org/node/2885228

Issue - #508

Steps for review:

  • Login as admin
  • Go to /admin/structure/types/manage/alert/fields/node.alert.field_alert_description
  • Check description on 'Description Field' field exists
  • Go to /admin/structure/types/manage/alert/fields/node.alert.field_alert_color
  • Check description on 'Background color' field exists
  • Go to /admin/structure/types/manage/alert/fields/node.alert.field_alert_link
  • Check description on 'Link' field exists
  • Go to /admin/structure/types/manage/alert/fields/node.alert.field_alert_place
  • Check description on 'Placement' field exists
  • Go to /admin/structure/types/manage/alert/fields/node.alert.field_alert_text_color
  • Check description on 'Text Color' field exists

Drupal Issue
https://www.drupal.org/node/2885228#comment-12123575

@andriibuda andriibuda requested a review from hamrant June 11, 2017 13:05
@andriibuda andriibuda added PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Jun 11, 2017
@andriibuda andriibuda self-assigned this Jun 11, 2017
@hamrant
Copy link
Contributor

hamrant commented Jun 11, 2017

ok to test

@ddrozdik ddrozdik added PR: Code Reviewed Code reviewed. Ready for QA and removed PR: Needs Review Needs someone review ( code ) labels Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 11, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 11, 2017
@gundevel
Copy link
Collaborator

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build1468
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build1468
Installation process http://install.openy-dev.ffwua.com/build1468/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/1468/

@hamrant hamrant merged commit 22c0d69 into ymcatwincities:8.x-1.x Jun 11, 2017
@Sanchiz Sanchiz mentioned this pull request Jun 11, 2017
Closed
@Sanchiz Sanchiz modified the milestone: Version 1.3 Jun 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ddrozdik ddrozdik ddrozdik approved these changes

@hamrant hamrant Awaiting requested review from hamrant

Assignees

@andriibuda andriibuda

Labels
PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed
Projects
None yet
Milestone
Version 1.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andriibuda @hamrant @gundevel @ddrozdik @Sanchiz