Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[OYPD-477] Gallery next/previous buttons are not keyboard operable. #547

Merged
merged 2 commits into from Jun 14, 2017
Merged

[OYPD-477] Gallery next/previous buttons are not keyboard operable. #547

merged 2 commits into from Jun 14, 2017

Conversation

ivan-berezhnov
Copy link
Contributor

@ivan-berezhnov ivan-berezhnov commented Jun 12, 2017

Make sure these boxes are checked before asking for review of your pull request - thank you!

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
    CI code sniffer errors
  • All tests are running and there are no failed tests reported by CI.
    Behat test results
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

Jira issue:

https://propeople-us.atlassian.net/browse/OYPD-477
Drupal.org issue: https://www.drupal.org/node/2885460

Steps to review:

  • Go to [sitename]/locations/west-ymca
  • Click "Tab" on keybord
  • When you have focused on the Left Arrow or Right in the Gallery
  • Verify you can see blue border near the Left Arrow or Right buttons

@ivan-berezhnov ivan-berezhnov self-assigned this Jun 12, 2017
@ivan-berezhnov ivan-berezhnov added PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Jun 12, 2017
@ivan-berezhnov ivan-berezhnov added this to the Version 1.3 milestone Jun 12, 2017
# Conflicts:
#	themes/openy_themes/openy_rose/css/styles.css.map
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 13, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 13, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 13, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 13, 2017
@Sanchiz Sanchiz added PR: Code Reviewed Code reviewed. Ready for QA and removed PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Jun 14, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 14, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 14, 2017
@ymcatwincities ymcatwincities deleted a comment from ivan-berezhnov Jun 14, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 14, 2017
@gundevel
Copy link
Collaborator

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build1531
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build1531
Installation process http://install.openy-dev.ffwua.com/build1531/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/1531/

@gundevel
Copy link
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Code Reviewed Code reviewed. Ready for QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants