Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[OYPD-496] Update default color scheme. #568

Merged
merged 2 commits into from Jun 19, 2017
Merged

[OYPD-496] Update default color scheme. #568

merged 2 commits into from Jun 19, 2017

Conversation

ivan-berezhnov
Copy link
Contributor

@ivan-berezhnov ivan-berezhnov commented Jun 15, 2017

Make sure these boxes are checked before asking for review of your pull request - thank you!

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
    CI code sniffer errors
  • All tests are running and there are no failed tests reported by CI.
    Behat test results
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

Jira issue:

https://propeople-us.atlassian.net/browse/OYPD-496
Drupal.org issue: https://www.drupal.org/node/2886628

Steps to review:

),
),
'bluesky' => array(
'title' => t('Blue sky'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Seattle.

@@ -41,7 +41,41 @@ $info = array(
// Pre-defined color schemes.
'schemes' => array(
'default' => array(
'title' => t('Blue sky (default)'),
'title' => t('Seattle (default)'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Blue Sky.

@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 15, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 15, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 15, 2017
@ivan-berezhnov ivan-berezhnov self-assigned this Jun 15, 2017
@ivan-berezhnov ivan-berezhnov added this to the Version 1.3 milestone Jun 15, 2017
@ivan-berezhnov ivan-berezhnov added PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Jun 15, 2017
@ivan-berezhnov ivan-berezhnov changed the title [OYPD-496] Add new theme "Seattle". [OYPD-496] Update default color scheme. Jun 15, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 16, 2017
@Sanchiz
Copy link
Contributor

Sanchiz commented Jun 16, 2017

Some colors are different. Make sure you've updated demo content to use appropriate colors.
image
image

@Sanchiz Sanchiz added PR: Needs Work Unfinished task. Issues still there and removed PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Jun 16, 2017
[OYPD-496] Update name

[OYPD-496] Update colors.css colors from new scheme.

[OYPD-496] Change color for banner and content in loading page.

[OYPD-496] Fix color for blue button.
@ivan-berezhnov
Copy link
Contributor Author

@Sanchiz #568 (comment)
Yeah, I saw it but I thought it fix subtask. Now I fixed it

# Conflicts:
#	themes/openy_themes/openy_rose/css/styles.css.map
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 19, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 19, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 19, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 19, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 19, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Jun 19, 2017
@gundevel
Copy link
Collaborator

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build1622
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build1622
Installation process http://install.openy-dev.ffwua.com/build1622/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/1622/

@gundevel
Copy link
Collaborator

@ivan-berezhnov ivan-berezhnov added PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Jun 19, 2017
@ivan-berezhnov ivan-berezhnov removed the PR: Needs Work Unfinished task. Issues still there label Jun 19, 2017
@ymcatwincities ymcatwincities deleted a comment from ivan-berezhnov Jun 19, 2017
@Sanchiz Sanchiz merged commit b544591 into ymcatwincities:8.x-1.x Jun 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants