Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[OYPD-584] Misc fixes. #751

Merged
merged 5 commits into from Aug 22, 2017
Merged

[OYPD-584] Misc fixes. #751

merged 5 commits into from Aug 22, 2017

Conversation

ivan-berezhnov
Copy link
Contributor

@ivan-berezhnov ivan-berezhnov commented Aug 16, 2017

Make sure these boxes are checked before asking for review of your pull request - thank you!

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
    CI code sniffer errors
  • All tests are running and there are no failed tests reported by CI.
    Behat test results
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

Jira issue:

https://propeople-us.atlassian.net/browse/OYPD-584
Drupal.org issues:
https://www.drupal.org/node/2902785
https://www.drupal.org/node/2902783
https://www.drupal.org/node/2902782

Steps to review:

  • login as admin
  • go to front page and in the section "What's happening at the Y?" click on a category in one of the item.
    Please look https://monosnap.com/file/q1IbA5AX3ZeebVQhRGLlXvZGdRDCpq
  • verify you can correct view as in this image https://monosnap.com/file/4YhkZJrfY4usSNd9uVdeDfqF2JQ2Cn
  • go to create a landing page /node/add/landing_page
  • verify in the "Layout" have option "Two column with fixed sidebar"
  • select "Two column with fixed sidebar" in the "Layout"
  • find 'SIDEBAR AREA' and add "Simple content" paragraph
  • add test text and save
  • logout and back to your page
  • scroll down
  • verify sidebar sticky at the top when you scroll down the page
  • go to /give page
  • login as admin
  • select "Two column with fixed sidebar" in the "Layout"
  • in the bottom section add Simple Content paragraph with text
  • in the main section add more text
  • in the sidebar add Promote paragraph and save
  • logout and back to your page
  • scroll down
  • verify sidebar sticky at the top when you scroll down the page and don't jump in the bottom

@ivan-berezhnov ivan-berezhnov self-assigned this Aug 16, 2017
@ivan-berezhnov ivan-berezhnov added the PR: Needs Work Unfinished task. Issues still there label Aug 16, 2017
@ivan-berezhnov ivan-berezhnov added this to the Version 1.5 milestone Aug 16, 2017
[OYPD-584] Add additional space for sidebar.
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
[OYPD-584] Fix name for filter.

fix
@ivan-berezhnov ivan-berezhnov added PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed and removed PR: Needs Work Unfinished task. Issues still there labels Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 16, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 18, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 18, 2017
[OYPD-583] Add hook update.

[OYPD-584] Fix hook update.

[OYPD-584] Fix js affix for sidebar.

[OYPD-584] Fix affix jump in the bottom.
@ivan-berezhnov ivan-berezhnov added PR: Needs Testing Manual testing is needed and removed PR: Needs Work Unfinished task. Issues still there PR: Tested Manually tested. Green light for merging labels Aug 21, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Aug 22, 2017
@ivan-berezhnov
Copy link
Contributor Author

retest this please

@gundevel
Copy link
Collaborator

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build2108
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build2108
Installation process http://install.openy-dev.ffwua.com/build2108/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/2108/

@gundevel
Copy link
Collaborator

Decoupling report http://ci.openymca.org/build2108

@gundevel
Copy link
Collaborator

Acessibility Sniffer: front page checking WCAG2AA http://ci.openymca.org/build2108/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://ci.openymca.org/build2108/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://ci.openymca.org/build2108/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://ci.openymca.org/build2108/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://ci.openymca.org/build2108/blogWCAG2AAhtmlcs.txt

@gundevel
Copy link
Collaborator

@ivan-berezhnov
Copy link
Contributor Author

@Sanchiz I fixed bugs from comment #751 (comment)
about the behat tests created the new issue https://propeople-us.atlassian.net/browse/OYPD-591
because data for tests сhanges after a while

@Sanchiz Sanchiz added PR: Code Reviewed Code reviewed. Ready for QA and removed PR: Needs Review Needs someone review ( code ) labels Aug 22, 2017
@AlexNetman AlexNetman added PR: Tested Manually tested. Green light for merging and removed PR: Needs Testing Manual testing is needed labels Aug 22, 2017
@AlexNetman AlexNetman merged commit 6f68e78 into ymcatwincities:8.x-1.x Aug 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants