Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[OYPD-590] Update groupex print url pattern. #765

Merged
merged 1 commit into from Sep 1, 2017

Conversation

Kerby70
Copy link
Contributor

@Kerby70 Kerby70 commented Aug 28, 2017

Jira https://propeople-us.atlassian.net/browse/OYPD-590
D.o https://www.drupal.org/node/2905105

Make sure these boxes are checked before asking for review of your pull request - thank you!

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
    CI code sniffer errors
  • All tests are running and there are no failed tests reported by CI.
    Behat test results
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

Steps for review

  • Go to /schedules/group-schedules?location=202&filter_date=8/28/17
  • Test print button (get pdf)
  • Go to /schedules/group-schedules-embedded
  • Test print link (get pdf)

@Kerby70
Copy link
Contributor Author

Kerby70 commented Aug 28, 2017

@Sanchiz Test is failing on changes to the external data, should these be removed?

@Kerby70 Kerby70 added the PR: Needs Review Needs someone review ( code ) label Aug 28, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Sep 1, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Sep 1, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Sep 1, 2017
@ymcatwincities ymcatwincities deleted a comment from gundevel Sep 1, 2017
@Sanchiz Sanchiz modified the milestone: Version 1.5 Sep 1, 2017
@gundevel
Copy link
Collaborator

gundevel commented Sep 1, 2017

Build comment file:

===============

Environment Link
Fresh OpenY installation http://ci.openymca.org/build2125
Upgraded(upgrade path) installation http://upgrade.openy-dev.ffwua.com/build2125
Installation process http://install.openy-dev.ffwua.com/build2125/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.openymca.org:8080/job/PR_BUILDER/2125/

@gundevel
Copy link
Collaborator

gundevel commented Sep 1, 2017

Decoupling report http://ci.openymca.org/build2125

@gundevel
Copy link
Collaborator

gundevel commented Sep 1, 2017

Acessibility Sniffer: front page checking WCAG2AA http://ci.openymca.org/build2125/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://ci.openymca.org/build2125/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://ci.openymca.org/build2125/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://ci.openymca.org/build2125/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://ci.openymca.org/build2125/blogWCAG2AAhtmlcs.txt

@gundevel
Copy link
Collaborator

gundevel commented Sep 1, 2017

@Sanchiz Sanchiz merged commit ed71d56 into ymcatwincities:8.x-1.x Sep 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Needs Review Needs someone review ( code )
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants