This repository has been archived by the owner on Sep 27, 2022. It is now read-only.
[PRODDEV-150] Update filter breakpoints according to theme. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duozersk
suggested changes
Apr 1, 2021
duozersk
suggested changes
Apr 2, 2021
manachynskyi
force-pushed
the
PRODDEV-150
branch
from
37df4e3
to
c49bab7
Compare
duozersk
approved these changes
Apr 2, 2021
podarok
suggested changes
Apr 2, 2021
| @@ -25,6 +26,12 @@ class ActivityFinder4Block extends BlockBase implements ContainerFactoryPluginIn | |||
|
|
|||
| use EntityBrowserFormTrait; | |||
|
|
|||
| const THEME_BOOTSTRAP_VERSION = [ | |||
| 'openy_carnation' => 4, | |||
There was a problem hiding this comment.
nice
But let's put this in config, please
manachynskyi
force-pushed
the
PRODDEV-150
branch
from
f47fec3
to
790eb6b
Compare
duozersk
approved these changes
Apr 8, 2021
podarok
approved these changes
Apr 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the task: https://openy.atlassian.net/browse/PRODDEV-150
Steps for review:
For dirrerent themes filters sibebar should be hidden on different resolutions (according to bootstrap version in AF settings form):
< 1060-filters' sidebar(left) hidden and displayed above results https://i.imgur.com/WXI6LYE.png>= 1060- filters' sidebar(left) displayed and top filters hidden https://i.imgur.com/PUaZDCz.png< 992- filters' sidebar(left) hidden and displayed above results https://i.imgur.com/pbGDRfc.png>= 992- filters' sidebar(left) displayed and top filters hidden https://i.imgur.com/TFnTAZv.png