Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-gpu transformers inference #272

Merged
merged 4 commits into from
May 11, 2023
Merged

Conversation

sunyuhan19981208
Copy link
Contributor

Add a script for multi-gpu inference

@airaria
Copy link
Contributor

airaria commented May 10, 2023

Is it possible to use one script for both single-gpu and multi-gpu inference (for instance, users can launch the script with --single-gpu (default) or --multi-gpu) ? so that we only have to maintain one script.

Copy link
Owner

@ymcui ymcui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions. We are indeed interested in your multi-gpu implementation. As requested, please consider merging the original inference script and yours into a unified one, so that the users can use with more flexibilities.

@sunyuhan19981208
Copy link
Contributor Author

Thank you for your contributions. We are indeed interested in your multi-gpu implementation. As requested, please consider merging the original inference script and yours into a unified one, so that the users can use with more flexibilities.

Okay, I will finish that work, thank you for your concern.

@sunyuhan19981208
Copy link
Contributor Author

Is it possible to use one script for both single-gpu and multi-gpu inference (for instance, users can launch the script with --single-gpu (default) or --multi-gpu) ? so that we only have to maintain one script.

Thank you for your advice. I will complete the task as per your instructions.

@ymcui ymcui requested a review from airaria May 10, 2023 10:08
Add an option for only using CPU
Copy link
Contributor

@airaria airaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have tested the code and it looks ok

@airaria airaria self-requested a review May 10, 2023 14:09
@airaria airaria merged commit 17fa371 into ymcui:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants