Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick try Colab Notebook #364

Merged
merged 3 commits into from
May 31, 2023
Merged

Conversation

sunyuhan19981208
Copy link
Contributor

@sunyuhan19981208 sunyuhan19981208 commented May 17, 2023

I provide a colab notebook which can quick try chinese llama in gradio demo.
Here is the url of the colab notebook: https://colab.research.google.com/drive/1mG8CwGub-hcoeo79FjfoWtxqOuu3P_y1?usp=sharing

截屏2023-05-17 下午5 02 40

@sunyuhan19981208 sunyuhan19981208 changed the title feat: support Colab quick try Add quick try Colab Notebook May 17, 2023
@airaria airaria self-requested a review May 22, 2023 07:37
@airaria airaria changed the base branch from main to gradio_notebook May 24, 2023 03:14
@airaria
Copy link
Contributor

airaria commented May 24, 2023

Would you mind if I copy and put your Colab notebook into the repo, so that the repo is self-contained?

@sunyuhan19981208
Copy link
Contributor Author

Would you mind if I copy and put your Colab notebook into the repo, so that the repo is self-contained?

Sure, you are welcome to copy and include the Colab notebook in your repository to make it self-contained.

@airaria
Copy link
Contributor

airaria commented May 24, 2023

After I click the submit, html tags are added to the texts (The input is "你好"):
screencast

Is there a way to remove them?
@sunyuhan19981208

@sunyuhan19981208
Copy link
Contributor Author

After I click the submit, html tags are added to the texts (The input is "你好"): screencast

Is there a way to remove them? @sunyuhan19981208

I think there is, I will try to fix that.

@sunyuhan19981208
Copy link
Contributor Author

After I click the submit, html tags are added to the texts (The input is "你好"): screencast

Is there a way to remove them? @sunyuhan19981208

截屏2023-05-29 上午11 52 38 I can't reproduce it...

@airaria
Copy link
Contributor

airaria commented May 30, 2023

@sunyuhan19981208 My colleague and I can both reproduce the problem with the notebook link you gave https://colab.research.google.com/drive/1mG8CwGub-hcoeo79FjfoWtxqOuu3P_y1?usp=sharing.

We have tested Safari + MacOS, Chrome + MacOS, Chrome + Win11, Edge + Win11. What is your environment?

@sunyuhan19981208
Copy link
Contributor Author

@sunyuhan19981208 My colleague and I can both reproduce the problem with the notebook link you gave https://colab.research.google.com/drive/1mG8CwGub-hcoeo79FjfoWtxqOuu3P_y1?usp=sharing.

We have tested Safari + MacOS, Chrome + MacOS, Chrome + Win11, Edge + Win11. What is your environment?

I have successfully reproduced it using a Colab notebook, but I encountered difficulties when trying to reproduce it on my local server. It's quite weird, but I assure you that I am committed to finding a solution. I apologize for any inconvenience caused, and I will put in extra effort to resolve this issue. Thank you for your understanding and patience.

@sunyuhan19981208
Copy link
Contributor Author

sunyuhan19981208 commented May 30, 2023

@sunyuhan19981208 My colleague and I can both reproduce the problem with the notebook link you gave https://colab.research.google.com/drive/1mG8CwGub-hcoeo79FjfoWtxqOuu3P_y1?usp=sharing.

We have tested Safari + MacOS, Chrome + MacOS, Chrome + Win11, Edge + Win11. What is your environment?

In the new commit 2ae52cb I delete the mdtex2html part, and then the chat message seems good.

@airaria
Copy link
Contributor

airaria commented May 31, 2023

@sunyuhan19981208 My colleague and I can both reproduce the problem with the notebook link you gave https://colab.research.google.com/drive/1mG8CwGub-hcoeo79FjfoWtxqOuu3P_y1?usp=sharing.
We have tested Safari + MacOS, Chrome + MacOS, Chrome + Win11, Edge + Win11. What is your environment?

In the new commit 2ae52cb I delete the mdtex2html part, and then the chat message seems good.

It looks good now.

@airaria
Copy link
Contributor

airaria commented May 31, 2023

We temporarily merge the PR into gradio_notebook branch, and then merge it into the main branch after reorganizing some code and docs.

@airaria airaria merged commit e430dfa into ymcui:gradio_notebook May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants