Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown sensors #57

Merged
merged 7 commits into from Nov 27, 2022
Merged

Unknown sensors #57

merged 7 commits into from Nov 27, 2022

Conversation

mboisson
Copy link
Contributor

This PR adds support for sensors of unknown device class. It also records the units of measurement. This can be used for example to address issue #53, or for any other type of sensor that is not explicitly supported

@ymerj
Copy link
Owner

ymerj commented Nov 17, 2022

Since this pertains to sensors, wouldn't it better to handle de device class definition in the sensor case instead of in the general section? Maybe other domain could use the same approach in future developement and would use a different way of defining the device class.

Also add the string version of the value for sensors that do not report numbers, but status
@mboisson
Copy link
Contributor Author

Since this pertains to sensors, wouldn't it better to handle de device class definition in the sensor case instead of in the general section? Maybe other domain could use the same approach in future developement and would use a different way of defining the device class.

This is done. I also added a string type value for sensors that do not report numbers but rather status.

Copy link
Collaborator

@tomwpublic tomwpublic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added version information and made a couple of cosmetic edits. Please check for correctness @mboisson . Thank you for the contribution!

@ymerj ymerj merged commit 34d3a82 into ymerj:main Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants